Skip to content

Rename and deprecate legacy Apiary NewClient factory - #18823

Draft
inadenenko wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
inadenenko:deprecate-compute-client-v2
Draft

Rename and deprecate legacy Apiary NewClient factory#18823
inadenenko wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
inadenenko:deprecate-compute-client-v2

Conversation

@inadenenko

Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

Rename and deprecate legacy Apiary NewClient factory

@modular-magician

modular-magician commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 059c4fb:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 31 files changed, 57 insertions(+), 55 deletions(-)
google-beta provider View Diff 34 files changed, 63 insertions(+), 61 deletions(-)
terraform-google-conversion View Diff 5 files changed, 11 insertions(+), 7 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
6933 6225 694 14
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 14 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
  • TestAccContainerCluster_autopilot_privileged_admission
  • TestAccContainerCluster_dataplaneOptimizationMode
  • TestAccContainerCluster_withNodeConfigKubeletConfigSettingsInNodePool
  • TestAccContainerCluster_withSoleTenantGroup
  • TestAccContainerNodePool_withHugepageConfig
  • TestAccContainerNodePool_withSoleTenantConfig
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated
  • TestAccVertexAISemanticGovernancePolicyEngine_basic

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
❌ Error · Log - TestAccContainerCluster_autopilot_privileged_admission
❌ Error · Log - TestAccContainerCluster_dataplaneOptimizationMode
❌ Error · Log - TestAccContainerCluster_withNodeConfigKubeletConfigSettingsInNodePool
❌ Error · Log - TestAccContainerCluster_withSoleTenantGroup
❌ Error · Log - TestAccContainerNodePool_withHugepageConfig
❌ Error · Log - TestAccContainerNodePool_withSoleTenantConfig
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample
❌ Error · Log - TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated
❌ Error · Log - TestAccVertexAISemanticGovernancePolicyEngine_basic

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@inadenenko VCR tests complete for 059c4fb!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants