Skip to content

Rename and deprecate legacy Apiary NewClient factory - #18702

Closed
inadenenko wants to merge 3 commits into
GoogleCloudPlatform:mainfrom
inadenenko:deprecate-compute-client
Closed

Rename and deprecate legacy Apiary NewClient factory#18702
inadenenko wants to merge 3 commits into
GoogleCloudPlatform:mainfrom
inadenenko:deprecate-compute-client

Conversation

@inadenenko

Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

Rename and deprecate legacy Apiary NewClient factory

@modular-magician

modular-magician commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit f880303:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 39 files changed, 70 insertions(+), 68 deletions(-)
google-beta provider View Diff 42 files changed, 76 insertions(+), 74 deletions(-)
terraform-google-conversion View Diff 4 files changed, 12 insertions(+), 8 deletions(-)

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

Step 1: Replaying Mode

Caution

Build Failure during VCR tests

🔴 REPLAYING mode: The following packages failed to build:

  • accessapproval
  • accesscontextmanager
  • acctest
  • activedirectory
  • agenticapplications
  • agentidentity
  • agentregistry
  • alloydb
  • allservices
  • apigateway
  • apigee
  • apihub
  • apikeys
  • appengine
  • apphub
  • artifactregistry
  • assuredworkloads
  • backupdr
  • beyondcorp
  • biglake
  • biglakehive
  • biglakeiceberg
  • bigquery
  • bigqueryanalyticshub
  • bigqueryconnection
  • bigquerydatapolicy
  • bigquerydatapolicyv2
  • bigquerydatatransfer
  • bigqueryreservation
  • bigtable
  • billingbudgets
  • binaryauthorization
  • blockchainnodeengine
  • certificatemanager
  • ces
  • chronicle
  • cloudasset
  • cloudbilling
  • cloudbuild
  • cloudbuildv2
  • clouddeploy
  • cloudfunctions
  • cloudfunctions2
  • cloudidentity
  • cloudids
  • cloudquotas
  • cloudrun
  • cloudrunv2
  • cloudscheduler
  • cloudsecuritycompliance
  • cloudsupport
  • cloudtasks
  • colab
  • composer
  • compute
  • config
  • contactcenterinsights
  • container
  • containeranalysis
  • containerattached
  • containeraws
  • containerazure
  • databasemigrationservice
  • datacatalog
  • dataflow
  • dataform
  • datafusion
  • datalineage
  • datalossprevention
  • datapipeline
  • dataplex
  • dataproc
  • dataprocgdc
  • dataprocmetastore
  • datastream
  • deploymentmanager
  • developerconnect
  • dialogflow
  • dialogflowcx
  • discoveryengine
  • dns
  • documentai
  • documentaiwarehouse
  • essentialcontacts
  • eventarc
  • filestore
  • firebase
  • firebaseailogic
  • firebaseappcheck
  • firebaseapphosting
  • firebasedatabase
  • firebasedataconnect
  • firebaseextensions
  • firebasehosting
  • firebaseremoteconfig
  • firebaserules
  • firebasestorage
  • firestore
  • functions
  • fwprovider
  • fwvalidators
  • gemini
  • gkebackup
  • gkehub
  • gkehub2
  • gkeonprem
  • healthcare
  • hypercomputecluster
  • iam2
  • iam3
  • iambeta
  • iamworkforcepool
  • iap
  • identityplatform
  • integrationconnectors
  • integrations
  • kms
  • licensemanager
  • logging
  • looker
  • lustre
  • managedkafka
  • memcache
  • memorystore
  • migrationcenter
  • modelarmor
  • modelarmorglobal
  • monitoring
  • netapp
  • networkconnectivity
  • networkconnectivityv1
  • networkmanagement
  • networksecurity
  • networkservices
  • notebooks
  • observability
  • oracledatabase
  • orgpolicy
  • osconfig
  • osconfigv2
  • oslogin
  • parallelstore
  • parametermanager
  • parametermanagerregional
  • privateca
  • privilegedaccessmanager
  • provider
  • publicca
  • pubsub
  • pubsublite
  • recaptchaenterprise
  • redis
  • resourcemanager
  • resourcemanagerv3
  • runtimeconfig
  • saasruntime
  • secretmanager
  • secretmanagerregional
  • securesourcemanager
  • securitycenter
  • securitycentermanagement
  • securitycenterv2
  • securityposture
  • securityscanner
  • servicedirectory
  • servicemanagement
  • servicenetworking
  • serviceusage
  • siteverification
  • sourcerepo
  • spanner
  • sql
  • storage
  • storagebatchoperations
  • storagecontrol
  • storageinsights
  • storagetransfer
  • sweeper
  • tags
  • terraform-provider-google-beta
  • testutils
  • tpuv2
  • transcoder
  • transport
  • universe
  • vectorsearch
  • vertexai
  • vertexaiaad
  • vmwareengine
  • vpcaccess
  • workbench
  • workflows
  • workloadidentity
  • workstations

Please fix the compilation errors to complete your PR.

View the build log

@inadenenko VCR tests complete for f880303!

@modular-magician

modular-magician commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 2488113:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 42 files changed, 75 insertions(+), 73 deletions(-)
google-beta provider View Diff 45 files changed, 81 insertions(+), 79 deletions(-)
terraform-google-conversion View Diff 7 files changed, 15 insertions(+), 11 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
6915 6212 696 7
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample
❌ Error · Log - TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@inadenenko VCR tests complete for 2488113!

@inadenenko
inadenenko force-pushed the deprecate-compute-client branch from 2488113 to 11e0868 Compare August 26, 2026 15:58
@modular-magician

modular-magician commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 11e0868:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 36 files changed, 68 insertions(+), 66 deletions(-)
google-beta provider View Diff 39 files changed, 74 insertions(+), 72 deletions(-)
terraform-google-conversion View Diff 5 files changed, 11 insertions(+), 7 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
6912 6205 692 15
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeRouterPeer_AddMd5AuthenticationKey
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
  • TestAccDataformConfig_update
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccHypercomputeclusterCluster_inPlaceUpdates
  • TestAccHypercomputeclusterCluster_new
  • TestAccHypercomputeclusterCluster_update
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccOracleDatabaseDbServers_basic
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated
  • TestAccVertexAISemanticGovernancePolicyEngine_basic

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeRouterPeer_AddMd5AuthenticationKey
✅ Log TestAccHypercomputeclusterCluster_inPlaceUpdates
✅ Log TestAccHypercomputeclusterCluster_new
✅ Log TestAccHypercomputeclusterCluster_update
✅ Log TestAccVertexAISemanticGovernancePolicyEngine_basic
✅ Log ❌ Error · Log TestAccProjectIamMemberRemove_memberInMultipleBindings
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
❌ Error · Log - TestAccDataformConfig_update
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccOracleDatabaseDbServers_basic
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample
❌ Error · Log - TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@inadenenko VCR tests complete for 11e0868!

@inadenenko
inadenenko force-pushed the deprecate-compute-client branch from 11e0868 to d44e328 Compare August 27, 2026 09:42
@modular-magician

modular-magician commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d44e328:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 34 files changed, 63 insertions(+), 61 deletions(-)
google-beta provider View Diff 37 files changed, 69 insertions(+), 67 deletions(-)
terraform-google-conversion View Diff 5 files changed, 11 insertions(+), 7 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
6929 6217 694 18
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 18 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccApigeeTargetServerListQuery_generated
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
  • TestAccContainerCluster_autopilot_privileged_admission
  • TestAccContainerCluster_dataplaneOptimizationMode
  • TestAccContainerCluster_withNodeConfigKubeletConfigSettingsInNodePool
  • TestAccContainerCluster_withNodePoolMultiple
  • TestAccContainerCluster_withSoleTenantGroup
  • TestAccContainerNodePool_withHugepageConfig
  • TestAccContainerNodePool_withSoleTenantConfig
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccKMSAutokeyConfig_kmsAutokeyUpdate
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccOracleDatabaseDbServers_basic
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccApigeeTargetServerListQuery_generated
✅ Log TestAccContainerCluster_withNodePoolMultiple
✅ Log TestAccKMSAutokeyConfig_kmsAutokeyUpdate
✅ Log ❌ Error · Log TestAccProjectIamMemberRemove_memberInMultipleBindings
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
❌ Error · Log - TestAccContainerCluster_autopilot_privileged_admission
❌ Error · Log - TestAccContainerCluster_dataplaneOptimizationMode
❌ Error · Log - TestAccContainerCluster_withNodeConfigKubeletConfigSettingsInNodePool
❌ Error · Log - TestAccContainerCluster_withSoleTenantGroup
❌ Error · Log - TestAccContainerNodePool_withHugepageConfig
❌ Error · Log - TestAccContainerNodePool_withSoleTenantConfig
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccOracleDatabaseDbServers_basic
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample
❌ Error · Log - TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@inadenenko VCR tests complete for d44e328!

@modular-magician

modular-magician commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit feecd17:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 34 files changed, 63 insertions(+), 61 deletions(-)
google-beta provider View Diff 37 files changed, 69 insertions(+), 67 deletions(-)
terraform-google-conversion View Diff 6 files changed, 12 insertions(+), 7 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
6929 6218 694 17
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeRouterPeer_AddMd5AuthenticationKey
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
  • TestAccContainerCluster_autopilot_privileged_admission
  • TestAccContainerCluster_dataplaneOptimizationMode
  • TestAccContainerCluster_withNodeConfigKubeletConfigSettingsInNodePool
  • TestAccContainerCluster_withSoleTenantGroup
  • TestAccContainerNodePool_withHugepageConfig
  • TestAccContainerNodePool_withSoleTenantConfig
  • TestAccDataformConfig_update
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccOracleDatabaseDbServers_basic
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccContainerCluster_withSoleTenantGroup
✅ Log TestAccProjectIamMemberRemove_memberInMultipleBindings
✅ Log ❌ Error · Log TestAccComputeRouterPeer_AddMd5AuthenticationKey
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
❌ Error · Log - TestAccContainerCluster_autopilot_privileged_admission
❌ Error · Log - TestAccContainerCluster_dataplaneOptimizationMode
❌ Error · Log - TestAccContainerCluster_withNodeConfigKubeletConfigSettingsInNodePool
❌ Error · Log - TestAccContainerNodePool_withHugepageConfig
❌ Error · Log - TestAccContainerNodePool_withSoleTenantConfig
❌ Error · Log - TestAccDataformConfig_update
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccOracleDatabaseDbServers_basic
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample
❌ Error · Log - TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@inadenenko VCR tests complete for feecd17!

@inadenenko

Copy link
Copy Markdown
Contributor Author

Opened new PR:

#18823

@inadenenko inadenenko closed this Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants