Conversation
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
# <Feature Name> ## Problem and Scope Debug messages were being always being printed in the .h file, even when they weren't requested. ## Description If 'generate: false' flag is written at message level, structs will not be printed onto .h file. Default remains to print all structs. ## Gotchas and Limitations Only works at the field level. Any "generate" flags written at the message level would not be valid. ## Testing - [ ] HOOTL testing - [ ] HITL testing - [ ] Human tested ### Testing Details ## Larger Impact ## Additional Context and Ticket Signed-off-by: coderask <62189577+coderask@users.noreply.github.com> Co-authored-by: coderask <62189577+coderask@users.noreply.github.com>
Signed-off-by: coderask <62189577+coderask@users.noreply.github.com>
3 tasks
# URL Reference Support for Web CANdo Viewer ## Problem and Scope No longer an unofficial tool Sharing a CANdo reference requires more steps than strictly necessary, reloading also resets the branch ## Description Remove the unofficial tool warning/alert banner Add support for parsing `?ref=<BRANCH>` and keep it up to date, which allows reloading, and shows `#custom` and `#edited` in the URL so that others know from a shared URL if it is a portable link or an incorrect copy ## Gotchas and Limitations Requires testing ## Testing - [x] HOOTL testing - [ ] HITL testing - [x] Human tested ### Testing Details Try to break it and see no errors or console warnings, needs more testing Due to changing how URL parsing works, the [htmlpreview](https://htmlpreview.github.io/?https://github.com/Gaucho-Racing/Firmware/blob/ViewerBonuses/Web/index.html) we normally use does not work, this is expected but painful ## Larger Impact Signal confidence in viewer Ease of use with references and reloading the page ## Additional Context and Ticket Hopefully no merge conflicts with #397 --------- Signed-off-by: Daniel Hansen <dchansen06@gmail.com> Signed-off-by: Daniel Hansen <105574022+dchansen06@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
dchansen06
added
Documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assorted Viewer Fixes (and Some Parser Fixes)
Problem and Scope
Miscellaneous features that were not shipped before the CAN migration.
Description
Gotchas and Limitations
Testing
Testing Details
Larger Impact
Additional Context and Ticket