Add URL Parsing Support For Web CANdo Viewer#405
Merged
coderask merged 5 commits intoViewer_Fixesfrom Apr 10, 2026
Merged
Conversation
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
…ment identifiers, this way we can easily share viewers on specific references and any shared link clearly shows custom/edited/etc by default Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
dchansen06
added
Enhancement
Signed-off-by: Daniel Hansen <105574022+dchansen06@users.noreply.github.com>
Contributor
Author
|
@coderask Please take a look when you get a chance, feel free to edit however you like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URL Reference Support for Web CANdo Viewer
Problem and Scope
No longer an unofficial tool
Sharing a CANdo reference requires more steps than strictly necessary, reloading also resets the branch
Description
Remove the unofficial tool warning/alert banner
Add support for parsing
?ref=<BRANCH>and keep it up to date, which allows reloading, and shows#customand#editedin the URL so that others know from a shared URL if it is a portable link or an incorrect copyGotchas and Limitations
Requires testing
Testing
Testing Details
Try to break it and see no errors or console warnings, needs more testing
Due to changing how URL parsing works, the htmlpreview we normally use does not work, this is expected but painful
Larger Impact
Signal confidence in viewer
Ease of use with references and reloading the page
Additional Context and Ticket
Hopefully no merge conflicts with #397