Added XML file location #116
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lennard0711
suggested changes
Dec 23, 2020
lennard0711
suggested changes
Dec 23, 2020
There was a problem hiding this comment.
This is a good idea but I would change it a bit since the user still needs to find out if their virt-manager has XML editing.
Apparently it was added in virt-manager 2.2.0 as I found here
Also editing the file directly on the filesystem is not recommended since it can change the permission on the file if handled incorrectly. It's recommended to use virsh edit <vmname>
Co-authored-by: Lennard Indlekofer <info@lennard0711.eu>
Author
|
Commited changes, thanks for reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Older" versions of systems like Ubuntu 18.10 has older versions of virt-manager on the default repos. For users like those, it's important to show them they can manually edit the XML file.