Skip to content

fix(errors): render the error banners that were being swallowed #8453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
talissoncosta wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −11
Open

fix(errors): render the error banners that were being swallowed #8453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
694f638
fix(errors): render the error banners that were being swallowed
talissoncosta Aug 28, 2026
a7dbe57
fix(errors): apply the class VariationOptions passes to its error
talissoncosta Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/web/components/EditIdentity.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ const EditIdentity: FC<EditIdentityType> = ({ data, environmentId }) => {
Edit
<Icon name='edit' width={16} />
</Button>
<ErrorMessage>{error}</ErrorMessage>
<ErrorMessage error={error} />
</>
)
}
Expand Down
2 changes: 1 addition & 1 deletion frontend/web/components/import-export/FeatureImport.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ const FeatureExport: FC<FeatureExportType> = ({ projectId }) => {
prevPage={() => setPage(page - 1)}
goToPage={setPage}
/>
<ErrorMessage>{error}</ErrorMessage>
<ErrorMessage error={error} />
<div className='mt-4 text-right'>
<Button disabled={isLoading} onClick={onSubmit}>
Import Features
Expand Down
2 changes: 1 addition & 1 deletion frontend/web/components/modals/ForgotPasswordModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ const ForgotPasswordModal: FC<ForgotPasswordModalType> = ({
onChange={(e: InputEvent) => setEmail(Utils.safeParseEventValue(e))}
/>

<ErrorMessage>{error}</ErrorMessage>
<ErrorMessage error={error} />
</div>
<ModalHR />
<div className='modal-footer'>
Expand Down
2 changes: 1 addition & 1 deletion frontend/web/components/mv/VariationOptions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export const VariationOptions: FC<VariationOptionsProps> = ({
<>
{invalid && (
<ErrorMessage
className='mt-2'
errorMessageClass='mt-2'
error='Your variation percentage splits total to over 100%'
/>
)}
Expand Down
6 changes: 2 additions & 4 deletions frontend/web/components/pages/AccountSettingsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ const AccountSettingsPage: FC = () => {
isValid={lastName && lastName.length}
type='text'
/>
{error && <ErrorMessage>{error}</ErrorMessage>}
{error && <ErrorMessage error={error} />}
<div className='text-right'>
<Button
type='submit'
Expand Down Expand Up @@ -395,9 +395,7 @@ const AccountSettingsPage: FC = () => {
isValid={newPassword2 && newPassword2.length}
type='password'
/>
{passwordError && (
<ErrorMessage>{passwordError}</ErrorMessage>
)}
{passwordError && <ErrorMessage error={passwordError} />}
<div className='text-right mt-5'>
<Button
type='submit'
Expand Down
2 changes: 1 addition & 1 deletion frontend/web/components/pages/AuditLogItemPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ const AuditLogItemPage: FC = () => {
</div>
) : (
<div>
<ErrorMessage>{error}</ErrorMessage>
<ErrorMessage error={error} />
{!!data && (
<>
<Panel title={'Details'} className='no-pad mb-2'>
Expand Down
2 changes: 1 addition & 1 deletion frontend/web/components/pages/FeatureHistoryDetailPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ const FeatureHistoryPage: FC = () => {
</div>
</PageTitle>
{!!(error || versionsError) && (
<ErrorMessage>{error || versionsError}</ErrorMessage>
<ErrorMessage error={error || versionsError} />
)}

{(isLoading || versionsLoading) && (
Expand Down
2 changes: 1 addition & 1 deletion frontend/web/components/pages/admin-dashboard/AdminDashboardPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ const AdminDashboardPage: FC = () => {
</div>
)}

<ErrorMessage>{error}</ErrorMessage>
<ErrorMessage error={error} />

{data && (
<>
Expand Down
Loading