fix(errors): render the error banners that were being swallowed - #8453
fix(errors): render the error banners that were being swallowed#8453talissoncosta wants to merge 2 commits into
Conversation
ErrorMessage takes an `error` prop and never renders children, but eight call sites passed children, so each returned null and the message never appeared. Failing to save your account details or change your password showed nothing at all. TypeScript had been reporting every one of these; they were buried in the existing error baseline.
ErrorMessage takes errorMessageClass, not className, so the margin was being dropped. Same misuse as the call sites above, caught by the same typecheck. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
the
front-end
Docker builds report
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (8)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe frontend updates ErrorMessage usage across identity editing, feature import, password recovery, variation options, account settings, audit logs, feature history, and the admin dashboard. Error values now use the Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The error banner fixes are mergeable based on current evidence; no concrete regression or exploitable path was confirmed. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #20114 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
🗂️ Previous results✅ private-cloud · depot-ubuntu-latest-16 — run #20114 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
✅ oss · depot-ubuntu-latest-16 — run #20114 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
✅ oss · depot-ubuntu-latest-arm-16 — run #20114 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
|
Visual Regression19 screenshots compared. See report for details. |
1 participant
Changes
ErrorMessagereads anerrorprop and returnsnullwithout one. Eight places passed the error as children instead, so nothing rendered at all: a failed password reset, a failed feature import, an identity edit, an audit log item, a feature history page, the admin dashboard and two spots in account settings all failed silently.A ninth passed
classNamewhere the component takeserrorMessageClass, so the error showed but unstyled.Found by typechecking those call sites:
npm run typecheckwent from 10ErrorMessagemisuse errors to 0.No change to
ErrorMessageitself.How did you test this code?
npm run typecheck, comparing theErrorMessageerrors before and after.Worth exercising one by hand: submit the forgot-password form with an address that does not exist, and confirm the error now appears.