Skip to content

[WIP]:test: verify visual regression CI after rebase#7142

Closed
talissoncosta wants to merge 3 commits intomainfrom
fix/visual-regression-ci
Closed

[WIP]:test: verify visual regression CI after rebase#7142
talissoncosta wants to merge 3 commits intomainfrom
fix/visual-regression-ci

Conversation

@talissoncosta
Copy link
Copy Markdown
Contributor

@talissoncosta talissoncosta commented Apr 6, 2026

Summary

  • Test PR to verify Kyle's visual regression changes pass CI after rebase on main
  • No code changes beyond rebase — this is just to check if E2E tests pass

Will be closed after CI runs.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 6, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment Apr 7, 2026 6:02pm
flagsmith-frontend-staging Ready Ready Preview, Comment Apr 7, 2026 6:02pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview Apr 7, 2026 6:02pm

Request Review

@talissoncosta talissoncosta marked this pull request as ready for review April 6, 2026 19:14
@talissoncosta talissoncosta requested review from a team as code owners April 6, 2026 19:14
@talissoncosta talissoncosta requested review from kyle-ssg and removed request for a team April 6, 2026 19:14
claude[bot]
claude bot reviewed Apr 6, 2026
View reviewed changes
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, reopen this pull request to trigger a review.

@talissoncosta talissoncosta changed the title test: verify visual regression CI after rebase [WIP]:test: verify visual regression CI after rebase Apr 6, 2026
@github-actions github-actions bot added testing and removed testing labels Apr 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 6, 2026 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-7142 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-7142 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-7142 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7142 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-7142 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-7142 Finished ✅ Results ✅

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Apr 6, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.34%. Comparing base (db4e578) to head (2cd17b4).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7142   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files        1336     1336           
  Lines       50174    50174           
=======================================
  Hits        49344    49344           
  Misses        830      830

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 6, 2026 •
edited
Loading

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  28.5 seconds
commit  703e9a7
info  🔄 Run: #15804 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  44.8 seconds
commit  703e9a7
info  🔄 Run: #15804 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  16 passed

Details

stats  16 tests across 13 suites
duration  1 minute, 10 seconds
commit  703e9a7
info  🔄 Run: #15804 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

failed  2 failed

Details

stats  2 tests across 2 suites
duration  23.9 seconds
commit  703e9a7
info  📦 Artifacts: View test results and HTML report
🔄 Run: #15804 (attempt 1)

Failed tests

firefox › tests/environment-test.pw.ts › Environment Tests › Environments can be created, renamed, and deleted @oss
firefox › tests/flag-tests.pw.ts › Flag Tests › Feature flags can be created, toggled, edited, and deleted across environments @oss

### Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  51.8 seconds
commit  da5d850
info  🔄 Run: #15805 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  52.8 seconds
commit  da5d850
info  🔄 Run: #15805 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  1 minute, 3 seconds
commit  da5d850
info  🔄 Run: #15805 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

failed  2 failed
passed  1 passed

Details

stats  3 tests across 3 suites
duration  23.6 seconds
commit  da5d850
info  📦 Artifacts: View test results and HTML report
🔄 Run: #15805 (attempt 1)

Failed tests

firefox › tests/environment-test.pw.ts › Environment Tests › Environments can be created, renamed, and deleted @oss
firefox › tests/flag-tests.pw.ts › Flag Tests › Feature flags can be created, toggled, edited, and deleted across environments @oss

### Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  44.7 seconds
commit  7421023
info  🔄 Run: #15806 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  36.3 seconds
commit  7421023
info  🔄 Run: #15806 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

failed  2 failed

Details

stats  2 tests across 2 suites
duration  23.1 seconds
commit  7421023
info  📦 Artifacts: View test results and HTML report
🔄 Run: #15806 (attempt 1)

Failed tests

firefox › tests/environment-test.pw.ts › Environment Tests › Environments can be created, renamed, and deleted @oss
firefox › tests/flag-tests.pw.ts › Flag Tests › Feature flags can be created, toggled, edited, and deleted across environments @oss

### Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  40 seconds
commit  c3ff681
info  🔄 Run: #15807 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  53.5 seconds
commit  c3ff681
info  🔄 Run: #15807 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  16 passed

Details

stats  16 tests across 13 suites
duration  38.1 seconds
commit  c3ff681
info  🔄 Run: #15807 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

failed  2 failed

Details

stats  2 tests across 2 suites
duration  23.6 seconds
commit  c3ff681
info  📦 Artifacts: View test results and HTML report
🔄 Run: #15807 (attempt 1)

Failed tests

firefox › tests/environment-test.pw.ts › Environment Tests › Environments can be created, renamed, and deleted @oss
firefox › tests/flag-tests.pw.ts › Flag Tests › Feature flags can be created, toggled, edited, and deleted across environments @oss

### Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  24.9 seconds
commit  4d30bb7
info  🔄 Run: #15809 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

failed  2 failed

Details

stats  2 tests across 2 suites
duration  24.4 seconds
commit  4d30bb7
info  📦 Artifacts: View test results and HTML report
🔄 Run: #15809 (attempt 1)

Failed tests

firefox › tests/environment-test.pw.ts › Environment Tests › Environments can be created, renamed, and deleted @oss
firefox › tests/flag-tests.pw.ts › Flag Tests › Feature flags can be created, toggled, edited, and deleted across environments @oss

### Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  1 minute, 8 seconds
commit  4d30bb7
info  🔄 Run: #15809 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  1 minute, 8 seconds
commit  4d30bb7
info  🔄 Run: #15809 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  48.6 seconds
commit  4d30bb7
info  🔄 Run: #15848 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

failed  2 failed

Details

stats  2 tests across 2 suites
duration  23.5 seconds
commit  4d30bb7
info  📦 Artifacts: View test results and HTML report
🔄 Run: #15848 (attempt 1)

Failed tests

firefox › tests/environment-test.pw.ts › Environment Tests › Environments can be created, renamed, and deleted @oss
firefox › tests/flag-tests.pw.ts › Flag Tests › Feature flags can be created, toggled, edited, and deleted across environments @oss

### Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  16 passed

Details

stats  16 tests across 13 suites
duration  1 minute, 8 seconds
commit  4d30bb7
info  🔄 Run: #15848 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  1 minute, 12 seconds
commit  4d30bb7
info  🔄 Run: #15848 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  44.3 seconds
commit  2cd17b4
info  🔄 Run: #15849 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  54.8 seconds
commit  2cd17b4
info  🔄 Run: #15849 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  17 passed

Details

stats  17 tests across 14 suites
duration  1 minute, 1 second
commit  2cd17b4
info  🔄 Run: #15849 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  49.7 seconds
commit  2cd17b4
info  🔄 Run: #15849 (attempt 1)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 6, 2026 •
edited
Loading

Visual Regression

16 screenshots compared. See report for details.
View full report

@talissoncosta talissoncosta removed request for a team and kyle-ssg April 6, 2026 20:05
@talissoncosta talissoncosta reopened this Apr 7, 2026
@talissoncosta talissoncosta changed the base branch from main to feat/visual-regression April 7, 2026 17:52
@talissoncosta talissoncosta requested review from a team as code owners April 7, 2026 17:52
@talissoncosta talissoncosta removed the request for review from a team April 7, 2026 17:52
@talissoncosta talissoncosta requested review from Holmus and Zaimwa9 and removed request for a team April 7, 2026 17:52
@talissoncosta talissoncosta changed the base branch from feat/visual-regression to main April 7, 2026 17:54
kyle-ssg and others added 2 commits April 7, 2026 14:58
@kyle-ssg @talissoncosta
Visual regression e2e
9a4aa64
@talissoncosta @claude
fix(e2e): move data-test from hidden input to visible wrapper in Envi…
2cd17b4 
…ronmentSelect

React Select puts rest props on the hidden <input>, making
data-test="switch-environment-*-active" invisible to Playwright's
waitForElementVisible. Move it to the wrapping <div> so the selector
resolves to a visible element.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@talissoncosta talissoncosta force-pushed the fix/visual-regression-ci branch from 386aef0 to 2cd17b4 Compare April 7, 2026 17:59
@talissoncosta talissoncosta mentioned this pull request Apr 7, 2026
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claude claude[bot] claude[bot] left review comments

@Holmus Holmus Awaiting requested review from Holmus Holmus was automatically assigned from Flagsmith/flagsmith-docs

@Zaimwa9 Zaimwa9 Awaiting requested review from Zaimwa9 Zaimwa9 was automatically assigned from Flagsmith/flagsmith-back-end

Assignees

No one assigned

Labels

front-end Issue related to the React Front End Dashboard testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@talissoncosta @kyle-ssg