Skip to content

fix(e2e): move data-test to visible wrapper in EnvironmentSelect#7161

Merged
kyle-ssg merged 1 commit intofeat/visual-regressionfrom
fix/environment-select-data-test
Apr 8, 2026
Merged

fix(e2e): move data-test to visible wrapper in EnvironmentSelect#7161
kyle-ssg merged 1 commit intofeat/visual-regressionfrom
fix/environment-select-data-test

Conversation

@talissoncosta
Copy link
Copy Markdown
Contributor

@talissoncosta talissoncosta commented Apr 7, 2026

  • I have read the Contributing Guide.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Fixes the ARM E2E timeout on the environment rename test.

React Select puts ...rest props (including data-test) on the hidden <input> element. Playwright's waitForElementVisible finds the element but it's always hidden — causing a 20s timeout after 44 resolution attempts.

The fix: extract data-test from rest props and put it on the visible wrapping <div> instead.

// Before: data-test lands on hidden <input> inside React Select
<Select {...rest} />  // rest includes data-test

// After: data-test on visible <div> wrapper
<div data-test={dataTestProp}>
  <Select {...rest} />
</div>

How did you test this code?

@talissoncosta @claude
fix(e2e): move data-test from hidden input to visible wrapper in Envi…
3373e35 
…ronmentSelect

React Select puts rest props on the hidden <input>, making
data-test="switch-environment-*-active" invisible to Playwright's
waitForElementVisible. Move it to the wrapping <div> so the selector
resolves to a visible element.

Fixes ARM E2E timeout on environment rename test.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@talissoncosta talissoncosta requested a review from a team as a code owner April 7, 2026 18:21
@talissoncosta talissoncosta requested review from kyle-ssg and removed request for a team April 7, 2026 18:21
claude[bot]
claude bot reviewed Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, reopen this pull request to trigger a review.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 7, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment Apr 7, 2026 6:23pm
flagsmith-frontend-staging Ready Ready Preview, Comment Apr 7, 2026 6:23pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Apr 7, 2026 6:23pm

Request Review

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Apr 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-7161 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-7161 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-e2e:pr-7161 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith:pr-7161 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7161 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-7161 Finished ✅ Results ✅

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026 •
edited
Loading

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  7.5 seconds
commit  3373e35
info  🔄 Run: #15850 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  48.4 seconds
commit  3373e35
info  🔄 Run: #15850 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  16 passed

Details

stats  16 tests across 13 suites
duration  56.9 seconds
commit  3373e35
info  🔄 Run: #15850 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  52.3 seconds
commit  3373e35
info  🔄 Run: #15850 (attempt 1)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

Visual Regression

16 screenshots compared. See report for details.
View full report

@talissoncosta talissoncosta mentioned this pull request Apr 7, 2026
Merged
4 tasks
@kyle-ssg kyle-ssg merged commit b6832e6 into feat/visual-regression Apr 8, 2026
23 checks passed
@kyle-ssg kyle-ssg deleted the fix/environment-select-data-test branch April 8, 2026 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claude claude[bot] claude[bot] left review comments

@kyle-ssg kyle-ssg Awaiting requested review from kyle-ssg kyle-ssg was automatically assigned from Flagsmith/flagsmith-front-end

Assignees

No one assigned

Labels

fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@talissoncosta @kyle-ssg