Fix outdated Certinia PSA bundle production install link#96351
Conversation
|
@chuckdries Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b15daa5b24
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }, | ||
|
|
||
| CERTINIA_PSA_BUNDLE_VERSION: '1.2', | ||
| CERTINIA_PSA_BUNDLE_VERSION: '1.3', |
There was a problem hiding this comment.
When the Certinia connection is opened in sandbox mode, CertiniaPrerequisitesStep still uses CERTINIA_PSA_BUNDLE_INSTALL_URL.SANDBOX while rendering this shared version constant. Since the sandbox URL remains 04t2M000002J0BH and this change's rationale says that package installs an older bundle than 1.3, sandbox users now see “Version 1.3” but are sent to the old package, reproducing the same misleading/install-failure path for isSandbox=true. Please either update the sandbox package ID to the 1.3 package as well or split the displayed version by environment.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
This seems valid but I'm not sure if it's important
|
🚧 yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.4.36-0 🚀
|
|
🤖 Help site review — changes required, draft PR opened. This PR corrected the Certinia PSA/SRP production install link in the app to package I opened a draft PR to correct the PSA/SRP installer link in both affected articles: #96360 — Docs updates for E/A#96351 correct Certinia PSA/SRP install link What changed
Both now point at The FFA and sandbox links were left unchanged (this PR only changed the PSA production package). The docs don't reference the bundle version number in text, so no version-copy change was needed there. @yuwenmemon, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
@yuwenmemon please help with the following steps: On the "Before you connect" step, verify the PSA/SRP bundle link reads "Install PSA/SRP Expensify Bundle (Version 1.3)". |
|
What's the issue exactly? You can find this under Workspace Settings > Accounting > Certinia > Connect as described in the first step |
|
@yuwenmemon Sorry I misunderstood the steps. No issue here. |
5 participants
Explanation of Change
Follow-up to #96340, which merged before its second commit landed. That PR's initial fix was wrong: it changed the "Version 1.3" copy to "1.2" to match what the production install link happened to download. The actual bug is the other way around - the link was outdated.
CERTINIA_PSA_BUNDLE_INSTALL_URL.PRODUCTIONpointed at the same Salesforce package ID asSANDBOX(04t2M000002J0BH), which installs an older package than the 1.3 the copy promises, causing a customer's install to fail. This reverts the version text to1.3and points the production link at the correct package (04t2M000002J0BM- the same one Expensify Classic's equivalent modal already uses).Fixed Issues
$
PROPOSAL:
Tests
.../installPackage.apexp?p0=04t2M000002J0BM.Offline tests
N/A - copy/link-only change, not network-dependent.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Not tested - no device/emulator available in this environment. This is a one-line URL fix using a shared constant, so it's not platform-dependent.
Android: mWeb Chrome
Not tested - see above.
iOS: Native
Not tested - see above.
iOS: mWeb Safari
Not tested - see above.
MacOS: Chrome / Safari
Verified in a browser: the "Before you connect" step reads "Install PSA/SRP Expensify Bundle (Version 1.3)" and the link's href points to
.../installPackage.apexp?p0=04t2M000002J0BM.