Skip to content

Fix outdated Certinia PSA bundle production install link#96340

Merged
yuwenmemon merged 1 commit into
mainfrom
yuwen-certinia-psa-bundle-version-typo
Jul 16, 2026
Merged

Fix outdated Certinia PSA bundle production install link#96340
yuwenmemon merged 1 commit into
mainfrom
yuwen-certinia-psa-bundle-version-typo

Conversation

@yuwenmemon

@yuwenmemon yuwenmemon commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

A customer installed the Certinia PSA/SRP bundle from this modal and hit an install error. The modal correctly says "Version 1.3", but the production install link pointed at package 04t2M000002J0BM's sandbox-only ID (also used for SANDBOX), which installs an older package than the one the text promises. This points the production link at the correct 1.3 package (matching the link Expensify Classic already uses).

Fixed Issues

$
PROPOSAL:

Tests

  1. Upgrade a workspace to the Control plan and open Workspace Settings > Accounting > Certinia > Connect.
  2. On the "Before you connect" step, verify the PSA/SRP bundle link still reads "Install PSA/SRP Expensify Bundle (Version 1.3)".
  3. Inspect the link's href and confirm it points to .../installPackage.apexp?p0=04t2M000002J0BM.
  • Verify that no errors appear in the JS console

Offline tests

N/A - copy/link-only change, not network-dependent.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Not tested - no device/emulator available in this environment. This is a one-line URL fix using a shared constant, so it's not platform-dependent.

Android: mWeb Chrome

Not tested - see above.

iOS: Native

Not tested - see above.

iOS: mWeb Safari

Not tested - see above.

MacOS: Chrome / Safari

Verified in a browser: the "Before you connect" step still reads "Install PSA/SRP Expensify Bundle (Version 1.3)" and the link's href now points to .../installPackage.apexp?p0=04t2M000002J0BM.

@yuwenmemon
yuwenmemon requested review from a team as code owners July 16, 2026 18:14
@melvin-bot
melvin-bot Bot requested review from chuckdries and trjExpensify and removed request for a team July 16, 2026 18:14
@melvin-bot

melvin-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown

@chuckdries Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@yuwenmemon
yuwenmemon merged commit d61702c into main Jul 16, 2026
44 checks passed
@yuwenmemon
yuwenmemon deleted the yuwen-certinia-psa-bundle-version-typo branch July 16, 2026 20:31
@github-actions

Copy link
Copy Markdown
Contributor

🚧 yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@yuwenmemon yuwenmemon changed the title Fix incorrect PSA bundle version in Certinia connection copy Fix outdated Certinia PSA bundle production install link Jul 16, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.4.36-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site changes are required for this PR — no draft PR created.

This PR's merged change is a single internal code constant, CERTINIA_PSA_BUNDLE_VERSION in src/CONST/index.ts. That value is never surfaced in any help article — the Certinia guides walk through the connection flow but don't reference a specific bundle version number — so there's nothing in docs/articles that tracks it and nothing to update.

What I checked
  • Searched all Certinia help articles (docs/articles/expensify-classic/connections/certinia/ and docs/articles/new-expensify/connections/certinia/) for bundle version references (1.2, 1.3, 1.4, "version") — none of the articles mention a PSA/SRP bundle version, so the constant flip has no doc counterpart.
  • Confirmed the articles reference the PSA/SRP installer only as a link, not by version or by a user-facing "Version X.X" label.

Unrelated pre-existing issue (out of scope, flagging only): the PSA/SRP installer links in both Certinia connect articles look malformed — Connect-To-Certinia.md:17 (Classic) and Connect-To-Certinia.md:27 (New Expensify) both point at ...?p0=04t2M000002J0BHD%252Fpackaging%252FinstallPackage.apexp%253Fp0%253D04t2M000002J0BH, which has a double-encoded suffix appended to the package ID. This predates this PR and isn't caused by it, so I did not create a doc PR for it — but it may be worth cleaning up separately.

yuwenmemon — no help site PR was created because this change isn't documented in docs/articles. Let me know if you'd like me to open a separate PR to fix the malformed installer links noted above.

@kavimuru

Copy link
Copy Markdown

@yuwenmemon please help with the following steps, how do we have to check Install PSA/SRP Expensify Bundle (Version 1.3)".

  1. On the "Before you connect" step, verify the PSA/SRP bundle link still reads "Install PSA/SRP Expensify Bundle (Version 1.3)".
  2. Inspect the link's href and confirm it points to .../installPackage.apexp?p0=04t2M000002J0BM.

@yuwenmemon

Copy link
Copy Markdown
Contributor Author

Ignore this one. It was reversed by #96351

@IuliiaHerets

Copy link
Copy Markdown

@yuwenmemon can we check it off?

@yuwenmemon

Copy link
Copy Markdown
Contributor Author

Yup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants