Fix outdated Certinia PSA bundle production install link#96340
Conversation
|
@chuckdries Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🚧 yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.4.36-0 🚀
|
|
No help site changes are required for this PR — no draft PR created. This PR's merged change is a single internal code constant, What I checked
Unrelated pre-existing issue (out of scope, flagging only): the PSA/SRP installer links in both Certinia connect articles look malformed —
|
|
@yuwenmemon please help with the following steps, how do we have to check Install PSA/SRP Expensify Bundle (Version 1.3)".
|
|
Ignore this one. It was reversed by #96351 |
|
@yuwenmemon can we check it off? |
|
Yup. |
Explanation of Change
A customer installed the Certinia PSA/SRP bundle from this modal and hit an install error. The modal correctly says "Version 1.3", but the production install link pointed at package
04t2M000002J0BM's sandbox-only ID (also used forSANDBOX), which installs an older package than the one the text promises. This points the production link at the correct 1.3 package (matching the link Expensify Classic already uses).Fixed Issues
$
PROPOSAL:
Tests
.../installPackage.apexp?p0=04t2M000002J0BM.Offline tests
N/A - copy/link-only change, not network-dependent.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Not tested - no device/emulator available in this environment. This is a one-line URL fix using a shared constant, so it's not platform-dependent.
Android: mWeb Chrome
Not tested - see above.
iOS: Native
Not tested - see above.
iOS: mWeb Safari
Not tested - see above.
MacOS: Chrome / Safari
Verified in a browser: the "Before you connect" step still reads "Install PSA/SRP Expensify Bundle (Version 1.3)" and the link's href now points to
.../installPackage.apexp?p0=04t2M000002J0BM.