add interactive 3D volume plotting to msmapper#39
Merged
Conversation
DanPorter
requested changes
Jun 18, 2026
DanPorter
left a comment
Collaborator
There was a problem hiding this comment.
file import needs changing and I've put a couple of other suggestions.
DanPorter
requested changes
Jun 18, 2026
DanPorter
left a comment
Collaborator
There was a problem hiding this comment.
Another suggestion to make the tests pass
DanPorter
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a plot_voxel_image function widget returns plotting widget and a save function.
Dependencies have also been added for ipywidget and plotly. kaleido is necessary for saving the produced figure as a static image.
There has also been some formatting changes.