Skip to content

add interactive 3D volume plotting to msmapper#39

Merged
NatLeung96 merged 6 commits into
mainfrom
nl/add-plotly-volume
Jun 18, 2026
Merged

add interactive 3D volume plotting to msmapper#39
NatLeung96 merged 6 commits into
mainfrom
nl/add-plotly-volume

Conversation

@NatLeung96

Copy link
Copy Markdown
Collaborator

This PR adds a plot_voxel_image function widget returns plotting widget and a save function.

Dependencies have also been added for ipywidget and plotly. kaleido is necessary for saving the produced figure as a static image.

There has also been some formatting changes.

@NatLeung96 NatLeung96 requested a review from DanPorter June 17, 2026 15:14

@DanPorter DanPorter left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file import needs changing and I've put a couple of other suggestions.

Comment thread mmg_toolbox/diffraction/msmapper.py Outdated
Comment thread mmg_toolbox/diffraction/msmapper.py Outdated
Comment thread pyproject.toml
Comment thread mmg_toolbox/diffraction/msmapper.py
Comment thread mmg_toolbox/diffraction/msmapper.py Outdated
Comment thread mmg_toolbox/diffraction/msmapper.py Outdated

@DanPorter DanPorter left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another suggestion to make the tests pass

Comment thread mmg_toolbox/diffraction/msmapper.py Outdated
Comment thread mmg_toolbox/diffraction/msmapper.py Outdated
Comment thread mmg_toolbox/diffraction/msmapper.py
@NatLeung96 NatLeung96 merged commit 3ec2fc6 into main Jun 18, 2026
10 checks passed
@NatLeung96 NatLeung96 deleted the nl/add-plotly-volume branch June 18, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants