Skip to content

fix(opencode): pass input args to augment hook and allow tool search in subagents #1933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chewji9875 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(opencode): pass input args to augment hook and allow tool search in subagents #1933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/cli/agent_profiles.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,6 +547,16 @@ static bool render_profile_text(profile_buffer_t *buffer, cbm_graph_profile_dial
}
return true;
case CBM_GRAPH_DIALECT_OPENCODE:
if (!profile_buffer_append(buffer, "---\ndescription: ") ||
!profile_buffer_append(buffer, description) ||
!profile_buffer_append(
buffer, "\nmode: subagent\npermission:\n \"*\": deny\n read: allow\n grep: "
"allow\n glob: allow\n tool_search: allow\n tool_search_regex: allow\n") ||
(direct && !append_permission_mcp_tools(buffer, dialect, tier)) ||
!profile_buffer_append(buffer, "---\n") || !profile_buffer_append(buffer, prompt)) {
return false;
}
return true;
case CBM_GRAPH_DIALECT_KILO:
if (!profile_buffer_append(buffer, "---\ndescription: ") ||
!profile_buffer_append(buffer, description) ||
Expand Down
2 changes: 1 addition & 1 deletion src/cli/client_adapter.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ char *cbm_client_adapter_opencode(const char *binary_path) {
" const tool = input?.tool === 'grep' ? 'Grep' : input?.tool === 'glob' ? 'Glob' "
": null;\n"
" if (!tool) return;\n"
" const extra = await augment(tool, output?.args);\n"
" const extra = await augment(tool, input?.args);\n"
" if (extra && typeof output?.output === 'string') {\n"
" output.output += '\\n' + extra;\n"
" }\n"
Expand Down
2 changes: 2 additions & 0 deletions tests/test_agent_clients.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1283,6 +1283,8 @@ TEST(client_adapter_opencode_sends_the_required_hook_event) {
ASSERT_NOT_NULL(js);
ASSERT_NOT_NULL(strstr(js, "hook_event_name: 'PreToolUse'"));
ASSERT_NOT_NULL(strstr(js, "tool.execute.after"));
ASSERT_NOT_NULL(strstr(js, "augment(tool, input?.args)"));
ASSERT_NULL(strstr(js, "output?.args"));
/* OpenCode reaches the tools over MCP already; this adapter must not
* register any, or we reintroduce the second tool surface. */
ASSERT_NULL(strstr(js, "registerTool"));
Expand Down
19 changes: 19 additions & 0 deletions tests/test_agent_profiles.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,24 @@ TEST(agent_profiles_omp_direct_has_prefixed_tools_and_handoff_excludes_mcp) {
PASS();
}

TEST(agent_profiles_opencode_allows_tool_search_and_subagent_permissions) {
char *direct = cbm_render_graph_profile(CBM_GRAPH_DIALECT_OPENCODE, CBM_GRAPH_TIER_VERIFY,
CBM_GRAPH_ACCESS_DIRECT, NULL);
ASSERT_NOT_NULL(direct);
ASSERT_NOT_NULL(strstr(direct, "mode: subagent\n"));
ASSERT_NOT_NULL(strstr(direct, " \"*\": deny\n"));
ASSERT_NOT_NULL(strstr(direct, " read: allow\n"));
ASSERT_NOT_NULL(strstr(direct, " grep: allow\n"));
ASSERT_NOT_NULL(strstr(direct, " glob: allow\n"));
ASSERT_NOT_NULL(strstr(direct, " tool_search: allow\n"));
ASSERT_NOT_NULL(strstr(direct, " tool_search_regex: allow\n"));
ASSERT_NOT_NULL(strstr(direct, " \"codebase-memory-mcp_search_graph\": allow\n"));
ASSERT_NOT_NULL(strstr(direct, " \"codebase-memory-mcp_check_index_coverage\": allow\n"));
ASSERT_NULL(strstr(direct, "delete_project"));
free(direct);
PASS();
}

SUITE(agent_profiles) {
RUN_TEST(agent_profiles_stable_tier_identity);
RUN_TEST(agent_profiles_direct_dialects_are_coverage_aware_and_read_only);
Expand All @@ -371,6 +389,7 @@ SUITE(agent_profiles) {
RUN_TEST(agent_profiles_codex_declares_transport_and_escapes_binary_path);
RUN_TEST(agent_profiles_vibe_uses_matching_prompt_identifier_and_contract);
RUN_TEST(agent_profiles_omp_direct_has_prefixed_tools_and_handoff_excludes_mcp);
RUN_TEST(agent_profiles_opencode_allows_tool_search_and_subagent_permissions);
RUN_TEST(agent_profiles_grok_uses_dispatcher_ids_and_named_inheritance);
RUN_TEST(agent_profiles_render_deterministically_and_reject_invalid_inputs);
}
Loading