fix(opencode): pass input args to augment hook and allow tool search in subagents - #1933
Open
Chewji9875 wants to merge 1 commit into
Open
Conversation
…in subagents - Fix client adapter passing output?.args instead of input?.args in tool.execute.after hook (closes DeusData#1737) - Add tool_search and tool_search_regex permissions to OpenCode subagent profiles so deferred MCP tools can be discovered and unblocked - Add regression tests for OpenCode adapter hook args and subagent profile permissions
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves two issues affecting OpenCode integration:
Fix
output?.argstypo in OpenCode plugin adapter (src/cli/client_adapter.c):In OpenCode's plugin API for
tool.execute.after(input, output), the arguments passed to the executed tool reside ininput?.args, whileoutputcontains the result (output?.output). Passingoutput?.argspassedundefined, causinghook-augmentto receive an empty payload{"tool_input":{}}and silently failing to augment search results with graph context (Closes Generated OpenCode plugin passes output?.args to hook-augment, so augmentation never fires #1737).Add
tool_searchandtool_search_regexpermissions to OpenCode subagent profiles (src/cli/agent_profiles.c):When OpenCode subagents are generated with
permission: "*": deny, they were grantedread,grep, andglobalongside direct MCP tool permissions. In environments with deferred MCP tool loading (e.g.openstellar-tool-search), OpenCode needstool_searchortool_search_regexto discover and unlock deferred tools. Adding these permissions enables subagents to unblock graph tools as intended.Changes
src/cli/client_adapter.c: Changedoutput?.argstoinput?.argsincbm_client_adapter_opencode.src/cli/agent_profiles.c: UpdatedCBM_GRAPH_DIALECT_OPENCODEsubagent template to allowtool_searchandtool_search_regex.tests/test_agent_clients.c: Added assertions verifyinginput?.argspresence andoutput?.argsabsence.tests/test_agent_profiles.c: Addedagent_profiles_opencode_allows_tool_search_and_subagent_permissionstest.Verification
./scripts/test.sh --suites "agent_clients agent_profiles"— 49/49 tests passing../scripts/build.sh.