Skip to content

Add branch tags to size metrics#23832

Draft
lucia-sb wants to merge 2 commits into
masterfrom
lucia-sb/add-size-branch-tags
Draft

Add branch tags to size metrics#23832
lucia-sb wants to merge 2 commits into
masterfrom
lucia-sb/add-size-branch-tags

Conversation

@lucia-sb
Copy link
Copy Markdown
Contributor

What does this PR do?

Adds a --branch option to ddev size status and includes a branch: tag on size metrics sent to Datadog. Updates the disk usage workflows to pass the branch name and send PR branch size metrics.

Motivation

Size metrics need to distinguish master measurements from PR branch measurements so Datadog can track both streams independently.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@lucia-sb lucia-sb added the qa/skip-qa Automatically skip this PR for the next QA label May 25, 2026 — with ChatGPT Codex Connector
@datadog-prod-us1-5
Copy link
Copy Markdown

datadog-prod-us1-5 Bot commented May 25, 2026

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 1 Pipeline job failed

PR All | test / j5a9585a / IBM ACE   View in Datadog   GitHub Actions

🔄 Retry job. This looks flaky and may succeed on retry. Failed to make a client connection to queue manager 'QM1' using hostname 'ibm-ace-mq' on port '1414': MQCC=2; MQRC=2538.

🧪 6 Tests failed in 1 job

PR All | run   GitHub Actions

All test failures are known flaky — job may pass on retry.

❄️ Known flaky: test_config[Metric collection disabled] from test_config.py   View in Datadog (Fix with Cursor)
RetryError[&lt;Future at 0x7f8905b1b9d0 state=finished raised RetryError&gt;]

Not introduced in this PR.

❄️ Known flaky: test_config[Resource stats collection disabled; message_flows enabled] from test_config.py   View in Datadog (Fix with Cursor)
RetryError[&lt;Future at 0x7f8905b1b9d0 state=finished raised RetryError&gt;]

Not introduced in this PR.

View all 6 test failures

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 90.91%
Overall Coverage: 87.50% (-0.45%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 44135e3 | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 25, 2026

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and Codecov settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

@codecov
Copy link
Copy Markdown

codecov Bot commented May 25, 2026

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.93%. Comparing base (ae6846b) to head (44135e3).

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ddev dev/testing dev/tooling qa/skip-qa Automatically skip this PR for the next QA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant