You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Removes the --dependency-sizes CLI option and all associated gh CLI calls that fetched dependency size artifacts from GitHub Actions. The ddev size status command now always resolves dependency sizes from local lockfiles.
Adds a --branch flag so metrics sent to Datadog include a branch: tag, and updates the disk-usage workflows so size metrics are sent for PR branches as well as master.
Motivation
Dependency resolution is now done in one step, so dependency sizes are already represented by the lockfiles merged into the repository. There is no need to fetch dependency sizes from GitHub Actions artifacts anymore.
Sending the branch as a metric tag allows Datadog to receive and distinguish size metrics from PR branches as well as master.
Review checklist (to be filled by reviewers)
Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged
🔄 Retry job. This looks flaky and may succeed on retry.
Connection to the IBM MQ queue manager 'QM1' failed using hostname 'ibm-ace-mq'. MQ reason code: 2538.
Check PR | run / Check PR changelog
🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration.
Changelog is required for package 'ddev'. Please run `ddev release changelog new` to add it.
PR All | test / j6f0ded4 / Strimzi
🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration.
Resource mapping for 'my-cluster' not found. Kafka CRD may not be installed while attempting to forward port, with current pod status pending.
❌ Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.98%. Comparing base (73276c7) to head (a72514e). ⚠️ Report is 3 commits behind head on master.
Additional details and impacted files 🚀 New features to boost your workflow:
❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
This original mixed PR can be closed once the split looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the
--dependency-sizesCLI option and all associatedghCLI calls that fetched dependency size artifacts from GitHub Actions. Theddev size statuscommand now always resolves dependency sizes from local lockfiles.Adds a
--branchflag so metrics sent to Datadog include abranch:tag, and updates the disk-usage workflows so size metrics are sent for PR branches as well as master.Motivation
Dependency resolution is now done in one step, so dependency sizes are already represented by the lockfiles merged into the repository. There is no need to fetch dependency sizes from GitHub Actions artifacts anymore.
Sending the branch as a metric tag allows Datadog to receive and distinguish size metrics from PR branches as well as master.
Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged