Skip to content

Remove gh artifact fetching and add branch tag to disk usage metrics#23826

Open
lucia-sb wants to merge 1 commit into
masterfrom
lucia-sb/measure-disk
Open

Remove gh artifact fetching and add branch tag to disk usage metrics#23826
lucia-sb wants to merge 1 commit into
masterfrom
lucia-sb/measure-disk

Conversation

@lucia-sb
Copy link
Copy Markdown
Contributor

@lucia-sb lucia-sb commented May 25, 2026

What does this PR do?

Removes the --dependency-sizes CLI option and all associated gh CLI calls that fetched dependency size artifacts from GitHub Actions. The ddev size status command now always resolves dependency sizes from local lockfiles.

Adds a --branch flag so metrics sent to Datadog include a branch: tag, and updates the disk-usage workflows so size metrics are sent for PR branches as well as master.

Motivation

Dependency resolution is now done in one step, so dependency sizes are already represented by the lockfiles merged into the repository. There is no need to fetch dependency sizes from GitHub Actions artifacts anymore.

Sending the branch as a metric tag allows Datadog to receive and distinguish size metrics from PR branches as well as master.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@lucia-sb lucia-sb requested a review from a team as a code owner May 25, 2026 07:49
@lucia-sb lucia-sb added the qa/skip-qa Automatically skip this PR for the next QA label May 25, 2026
@datadog-prod-us1-3
Copy link
Copy Markdown

datadog-prod-us1-3 Bot commented May 25, 2026

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 4 Pipeline jobs failed

PR All | test / j5a9585a / IBM ACE   View in Datadog   GitHub Actions

🔄 Retry job. This looks flaky and may succeed on retry. Connection to the IBM MQ queue manager 'QM1' failed using hostname 'ibm-ace-mq'. MQ reason code: 2538.

Check PR | run / Check PR changelog   View in Datadog   GitHub Actions

🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration. Changelog is required for package 'ddev'. Please run `ddev release changelog new` to add it.

PR All | test / j6f0ded4 / Strimzi   View in Datadog   GitHub Actions

🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration. Resource mapping for 'my-cluster' not found. Kafka CRD may not be installed while attempting to forward port, with current pod status pending.

View all 4 failed jobs.

🧪 6 Tests failed in 1 job

PR All | run   GitHub Actions

All test failures are known flaky — job may pass on retry.

❄️ Known flaky: test_config[Metric collection disabled] from test_config.py   View in Datadog (Fix with Cursor)
RetryError[&lt;Future at 0x7fbc9c26b9d0 state=finished raised RetryError&gt;]

Not introduced in this PR.

❄️ Known flaky: test_config[Resource stats collection disabled; message_flows enabled] from test_config.py   View in Datadog (Fix with Cursor)
RetryError[&lt;Future at 0x7fbc9c26b9d0 state=finished raised RetryError&gt;]

Not introduced in this PR.

View all 6 test failures

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 94.12%
Overall Coverage: 87.58% (+0.21%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a72514e | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 25, 2026

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and Codecov settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

@codecov
Copy link
Copy Markdown

codecov Bot commented May 25, 2026

Codecov Report

❌ Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.98%. Comparing base (73276c7) to head (a72514e).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor Author

Superseded by the split draft PRs:

This original mixed PR can be closed once the split looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant