ci: migrate macOS jobs to tart VM runner#1335
Draft
alee1246 wants to merge 3 commits into
Draft
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 635e1be | Docs | Datadog PR Page | Give us feedback! |
The test:native-android job (and benchmarks build-and-upload:app) failed with "Unable to locate a Java Runtime" when running sdkmanager. Java 17 is installed in the tart VM image, but openjdk@17 is keg-only and the image only exports JAVA_HOME/PATH in ~/.zshrc — which the tart runner's non-interactive shell does not source. Export JAVA_HOME/PATH in the install-android-sdk snippet so sdkmanager can find Java. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate the macOS GitLab CI jobs from dedicated
macos:sonoma/specific:truerunners to virtualizedmacos:tartrunners, using the repo-specific tart VM image (dd-sdk-reactnative-sonoma).Migrated jobs:
test:lint,test:js,test:build,test:native-android,test:native-ios,test:native-ios-sr,test:native-ios-newarch, andbuild-and-upload:app(benchmarks pipeline).VM image:
packer/macos-vm/team/dd-sdk-reactnative-sonoma.pkr.hcl→486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/ci-platform-machine-images/tart-vm:dd-sdk-reactnative-sonoma-latestMotivation
The virtualized tart runners have a number of benefits over dedicated macOS runners:
mac2.metalhostmac2.metalhosts → cost reduction from needing fewer instancesChanges
.gitlab-ci.ymltest:*job tags frommacos:sonoma/specific:truetomacos:tartand pin the repo-specific tart VM imagebenchmarks/.benchmarks-ci.ymlbuild-and-upload:apptags tomacos:tartand pin the repo-specific tart VM imageTest plan
test:*jobs pass on the tart runnerbuild-and-upload:apppasses on the tart runner🤖 Generated with Claude Code