Skip to content

fix: use crate name dakera-cli in install-test workflow (not binary name dk) #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ferhimedamine merged 2 commits into from
May 21, 2026
Merged

fix: use crate name dakera-cli in install-test workflow (not binary name dk) #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f3a2ab
fix(DAK-5433): clear stale deb/rpm artifacts before build + enforce b…
ferhimedamine May 21, 2026
bc5f8be
fix: use crate name dakera-cli in install-test workflow (not binary n…
ferhimedamine May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 7 additions & 14 deletions .github/workflows/install-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,16 @@ on:
branches: [main]

jobs:
# NOTE: Homebrew tap (dakera-ai/homebrew-tap) is private.
# brew install requires a public tap. These jobs run with continue-on-error until
# the tap is made public (requires founder approval per org security policy).
test-brew-dk:
name: Homebrew — dk
runs-on: macos-latest
continue-on-error: true
steps:
- name: Install dk via Homebrew
run: brew install dakera-ai/tap/dk
- name: Verify dk version
run: dk --version


test-apt:
name: APT — dk
runs-on: ubuntu-22.04
Expand Down Expand Up @@ -58,35 +55,31 @@ jobs:
- name: Verify dk version
run: dk --version

# NOTE: cargo install and cargo binstall require dk to be published on crates.io.
# These jobs are expected to fail until that happens. Tracked in DAK-5436.
test-cargo-install:
name: cargo install — dk
name: cargo install — dakera-cli
runs-on: ubuntu-latest
continue-on-error: true
steps:
- uses: dtolnay/rust-toolchain@stable
- uses: actions/cache@v4
with:
path: ~/.cargo/registry
key: cargo-install-${{ runner.os }}-${{ github.run_id }}
restore-keys: cargo-install-${{ runner.os }}-
- name: Install dk from crates.io
run: cargo install dk --locked
- name: Install dakera-cli from crates.io
run: cargo install dakera-cli --locked
- name: Verify dk version
run: dk --version

test-cargo-binstall:
name: cargo binstall — dk
name: cargo binstall — dakera-cli
runs-on: ubuntu-latest
continue-on-error: true
steps:
- name: Install cargo-binstall
run: |
curl -L --proto '=https' --tlsv1.2 -sSf \
https://raw.githubusercontent.com/cargo-bins/cargo-binstall/main/install-from-binstall-release.sh \
| bash
- name: Install dk via binstall
run: cargo binstall dk --no-confirm
- name: Install dakera-cli via binstall
run: cargo binstall dakera-cli --no-confirm
- name: Verify dk version
run: dk --version
8 changes: 6 additions & 2 deletions .github/workflows/publish-linux-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ jobs:
- name: Install cargo-deb
run: cargo install cargo-deb --locked
- name: Build .deb package
run: cargo deb
run: |
rm -rf target/debian/
cargo deb
- name: Upload deb artifact
uses: actions/upload-artifact@v4
with:
Expand All @@ -52,7 +54,9 @@ jobs:
- name: Build release binary
run: cargo build --release
- name: Build .rpm package
run: cargo generate-rpm
run: |
rm -rf target/generate-rpm/
cargo generate-rpm
- name: Upload rpm artifact
uses: actions/upload-artifact@v4
with:
Expand Down