Skip to content

fix: use crate name dakera-cli in install-test workflow (not binary name dk)#87

Merged
ferhimedamine merged 2 commits into
mainfrom
fix/install-test-crate-name
May 21, 2026
Merged

fix: use crate name dakera-cli in install-test workflow (not binary name dk)#87
ferhimedamine merged 2 commits into
mainfrom
fix/install-test-crate-name

Conversation

@ferhimedamine
Copy link
Copy Markdown
Contributor

Summary

  • Fixed cargo install dkcargo install dakera-cli (crate name, not binary name)
  • Fixed cargo binstall dkcargo binstall dakera-cli
  • Removed continue-on-error: true from both jobs — dakera-cli v0.6.0 is live on crates.io
  • Removed stale NOTE comment about DAK-5436 / crates.io publish pending

Root Cause

Platform wrote the original workflow using the binary name (dk) instead of the crate name (dakera-cli). cargo install and cargo binstall require the crate name; the binary name is what gets installed to PATH.

Verification

  • dakera-cli v0.6.0 confirmed published to crates.io (publish-crate workflow ran 2026-05-21T07:56Z)
  • cargo install dakera-cli --locked and cargo binstall dakera-cli --no-confirm will resolve correctly now

Test plan

  • CI green on this PR (existing tests pass)
  • Trigger workflow_dispatch on install-test after merge to confirm test-cargo-install and test-cargo-binstall both pass

Closes DAK-5443 / DAK-5442

🤖 Generated with Claude Code

ferhimedamine and others added 2 commits May 21, 2026 14:16
…rew tests

Two fixes:
- publish-linux-packages.yml: rm -rf target/debian/ and target/generate-rpm/
  before building. A cache hit on `target/` left the old `dakera-cli_*.deb`
  alongside the new `dk_*.deb`; head -1 in the publish step picked the wrong
  one alphabetically. Clearing ensures only the freshly-named package exists.
- install-test.yml: remove continue-on-error from brew jobs now that
  homebrew-tap is public (DAK-5437 resolved).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ame dk)

cargo install and cargo binstall require the crate name, not the binary
name. The crate is published as dakera-cli on crates.io and installs the
dk binary. Also removes continue-on-error and the stale DAK-5436 NOTE
comment now that dakera-cli v0.6.0 is live on crates.io.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ferhimedamine ferhimedamine added the auto-merge Auto-merge when CI passes label May 21, 2026
@ferhimedamine ferhimedamine merged commit 98ad62f into main May 21, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge Auto-merge when CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant