-
Notifications
You must be signed in to change notification settings - Fork 512
i18n: Translate new keys for pt-BR #4962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
t-rodrigues
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve reviewed the pull request and left a few minor suggestions, mostly related to wording and consistency.
Overall, looks good.
Revisei o pull request e deixei algumas sugestões, principalmente relacionadas à escrita e à consistência.
Co-authored-by: Thiago Rodrigues <thiagor_@live.com>
|
Thank you for reviewing my PR @t-rodrigues Agradeço por revisar meu PR @t-rodrigues |
t-rodrigues
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the suggested translation adjustments. I’ve reviewed the updates and everything looks consistent now. Approving the PR.
Obrigado por ajustar as sugestões de tradução. Revisei as alterações e agora está tudo consistente. PR aprovado.
tdonohue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks @JohnnyMendesC ! Looks good to me too. I performed basic tests just to ensure the new translations appear.
|
Successfully created backport PR for |
References
Description
This PR updates the Portuguese (Brazil) translation file (
src/assets/i18n/pt-BR.json5). It addresses approximately 290 keys previously marked as// TODO New key - Add a translationand// TODO Source message changed - Revise the translation, covering generic messages, admin curation tasks, bitstream formats, external login, and LDN/COAR Notify services.Instructions for Reviewers
List of changes in this PR:
TODO.// TODO New key - Add a translationand// TODO Source message changed - Revise the translation.Guidance for testing:
Português (Brasil).Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.