Skip to content

Conversation

@JohnnyMendesC
Copy link
Contributor

References

  • No specific issue ticket. Addresses pending translation keys in the codebase.

Description

This PR updates the Portuguese (Brazil) translation file (src/assets/i18n/pt-BR.json5). It addresses approximately 290 keys previously marked as // TODO New key - Add a translation and // TODO Source message changed - Revise the translation, covering generic messages, admin curation tasks, bitstream formats, external login, and LDN/COAR Notify services.

Instructions for Reviewers

List of changes in this PR:

  • Translated ~290 keys marked as TODO.
  • Removed the // TODO New key - Add a translation and // TODO Source message changed - Revise the translation.

Guidance for testing:

  1. Switch the UI language to Português (Brasil).
  2. Verify that the newly translated keys (e.g., in Admin > Curation Tasks or LDN Services) appear correctly and are not falling back to English.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added i18n / l10n Internationalisation and localisation, related to message catalogs 1 APPROVAL pull request only requires a single approval to merge labels Jan 5, 2026
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Jan 5, 2026
Copy link
Contributor

@t-rodrigues t-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve reviewed the pull request and left a few minor suggestions, mostly related to wording and consistency.
Overall, looks good.

Revisei o pull request e deixei algumas sugestões, principalmente relacionadas à escrita e à consistência.

@github-project-automation github-project-automation bot moved this from 🙋 Needs Reviewers Assigned to 👀 Under Review in DSpace 10.0 Release Jan 14, 2026
Co-authored-by: Thiago Rodrigues <thiagor_@live.com>
@JohnnyMendesC
Copy link
Contributor Author

Thank you for reviewing my PR @t-rodrigues
I've checked the suggestions you left and they were all helpful and precise, so I added them to the last commit.

Agradeço por revisar meu PR @t-rodrigues
Verifiquei as sugestões que você deixou e todas foram de grande ajuda e precisas, então as adicionei ao último commit.

Copy link
Contributor

@t-rodrigues t-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the suggested translation adjustments. I’ve reviewed the updates and everything looks consistent now. Approving the PR.

Obrigado por ajustar as sugestões de tradução. Revisei as alterações e agora está tudo consistente. PR aprovado.

@tdonohue tdonohue added this to the 10.0 milestone Feb 11, 2026
@tdonohue tdonohue moved this from 👀 Under Review to 👍 Reviewer Approved in DSpace 10.0 Release Feb 11, 2026
@tdonohue tdonohue added the port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release label Feb 11, 2026
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @JohnnyMendesC ! Looks good to me too. I performed basic tests just to ensure the new translations appear.

@tdonohue tdonohue merged commit fde7454 into DSpace:main Feb 11, 2026
16 checks passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 10.0 Release Feb 11, 2026
@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-9_x:

@tdonohue tdonohue removed the port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release label Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants