test(testnet): follow same-origin NFT links in the current tab by JOY · Pull Request #275 · DOS/DOScan

JOY (JOY) · 2026-10-25T14:31:10Z

Summary

Correct the Testnet browser acceptance test to follow the live anchor target: same-origin NFT links have no target and navigate the existing page; only _blank links require a popup.
Only close a child tab, never the test parent page.
Add a text guard for both navigation branches. It failed against the old popup-only spec and passes with the correction.

Verification

Independent full delta review of f537c03..1ac2650: CLEAN_PASS, no P0-P3 findings.
node --check and git diff --check pass; affected guard red-to-green.
Actual Testnet browser activation from the DOS Name domain link navigated the same tab to the canonical ERC-1155 instance, showing its full ID and owner. The href is public HTTPS; target is null.
Runtime revision f537c03 is already deployed successfully (run 40200373407), with exact Compose/code hashes and healthy adapter verified on VM. This PR changes tests only; neither path matches Deploy Config push triggers, so no runtime redeployment is required.
Hosted browser CI was Cloudflare-skipped and is not counted as passing UI coverage. Real browser evidence supplies the navigation acceptance. Required final-head dependency CI remains a merge gate.
Mainnet remains untouched. This is not authenticated DOS.Me user claim/renew E2E evidence.

📌 TL;DR

This PR updates the Testnet UI E2E test to handle token links that navigate in the same tab (rather than always opening a popup), and adds a corresponding unit test to enforce this navigation logic in the test suite.

🎯 Type of Change

🔍 Changes Walkthrough

File	Summary of Changes
`.github/scripts/testnet-bens-ui.spec.mjs`	Modified the "DOS Name search" test to dynamically check the `target` attribute of the token link. If `target="_blank"`, it waits for a popup; otherwise, it navigates in the current page. It also prevents closing the main page if navigation occurred in the same tab.
`.github/scripts/tests/test_validate_testnet_bens.py`	Added a new test case `test_browser_nft_guard_accepts_same_tab_and_popup_navigation` that verifies the E2E spec file contains the expected logic for handling both same-tab and popup navigation scenarios.

📊 Architectural Flow

flowchart TD
    A[Start Test: DOS Name Search] --> B[Locate Token Link]
    B --> C{Check 'target' Attribute}
    C -->|"_blank"| D[Wait for Popup Event]
    C -->|Other| E[Click Link in Same Tab]
    D --> F[Set tokenPage to Popup]
    E --> G[Set tokenPage to Main Page]
    F --> H[Wait for DOM Content Loaded]
    G --> H
    H --> I[Assert URL & Content]
    I --> J{Is tokenPage != Main Page?}
    J -->|Yes| K[Close Popup]
    J -->|No| L[Skip Close]
    K --> M[End Test]
    L --> M

claude

⚠️ Code review skipped — your organization has no extra usage available to pay for this review.

If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.

Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.

chatgpt-codex-connector · 2026-10-25T14:31:17Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	⚠️ Failed 2026-10-25T14:31:14.799830Z We couldn’t complete this review. Comment `@codex review` to try again.	`1ac2650`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "Codex (@codex) review" or "Codex (@codex) security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector · 2026-10-25T14:31:19Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

coderabbitai · 2026-10-25T14:31:21Z

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 4 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: c341d4a6-a0b0-4c7b-9e4e-0c074cba6428

Commits

Reviewing files that changed from the base of the PR and between f537c03 and f561667.

Files selected for processing: 2

.github/scripts/testnet-bens-ui.spec.mjs
.github/scripts/tests/test_validate_testnet_bens.py

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

dos

⏱️ Code Review completed (2 eligible files · 2,491 chars · 1 model call(s) · 1 PR unit(s))

Whole diff with bounded context at base f537c03 / head 1ac2650.

✅ CLEAN_PASS: Complete diff reviewed

gemini-code-assist

Code Review

This pull request updates the Playwright test suite to support both same-tab and popup navigation based on the token link's target attribute, and adds a Python unit test to verify these changes. Feedback suggests wrapping the waitForLoadState call in a conditional check to prevent potential race conditions during same-tab navigation, and using regular expressions in the Python unit test instead of exact string matching to make the test more robust against minor formatting changes.

dos

⏱️ Code Review completed (2 eligible files · 2,663 chars · 1 model call(s) · 1 PR unit(s))

Whole diff with bounded context at base f537c03 / head f561667.

✅ CLEAN_PASS: Complete diff reviewed

JOY (JOY) · 2026-10-25T14:40:24Z

Final-head independent delta review of f561667 is CLEAN_PASS, no P0-P3 findings. Both native comments were fixed and resolved; affected source guard, node syntax and diff checks pass. Actual browser search-to-address and domain-to-NFT flows have now completed on the deployed runtime, with same-tab navigation confirmed. Required final-head CI remains the only merge gate. This PR is test-only and does not trigger a runtime deployment.

JOY (JOY) · 2026-10-25T14:43:48Z

Completed: final-head dependency CI run 40203120252 passed, including 104 tests in 45.462s and real pinned adapter startup. Required review/conversation gates passed; merged as 33f1e90. Merged tree is identical to reviewed/tested head f561667. This test-only merge leaves the verified Testnet runtime at f537c03; Deploy Config was not triggered. Runtime/browser/contract acceptance and explicit limitations are recorded on PR274.

test(testnet): follow same-tab DOS Name NFT links

1ac2650

claude Bot reviewed Oct 25, 2026

View reviewed changes

dos Bot approved these changes Oct 25, 2026

View reviewed changes

gemini-code-assist Bot reviewed Oct 25, 2026

View reviewed changes

Comment thread .github/scripts/testnet-bens-ui.spec.mjs Outdated

Comment thread .github/scripts/tests/test_validate_testnet_bens.py Outdated

test(testnet): refine NFT navigation wait and source guards

f561667

dos Bot approved these changes Oct 25, 2026

View reviewed changes

JOY (JOY) mentioned this pull request Oct 25, 2026

fix(testnet): isolate read-only ENSv2 adapter manifest mount #274

Merged

2 of 6 tasks

JOY (JOY) merged commit 33f1e90 into main Oct 25, 2026
16 checks passed

Navigation Menu

Repository navigation

test(testnet): follow same-origin NFT links in the current tab - #275

test(testnet): follow same-origin NFT links in the current tab#275
JOY (JOY) merged 2 commits into
mainfrom
codex/testnet-nft-navigation-test

JOY (JOY) commented Oct 25, 2026 •

edited by dos Bot

Loading

Uh oh!

claude Bot left a comment

Uh oh!

chatgpt-codex-connector Bot commented Oct 25, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 25, 2026

Uh oh!

coderabbitai Bot commented Oct 25, 2026 •

edited

Loading

Review limit reached

Uh oh!

dos Bot left a comment

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

dos Bot left a comment

Uh oh!

JOY (JOY) commented Oct 25, 2026

Uh oh!

Uh oh!

JOY (JOY) commented Oct 25, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

JOY (JOY) commented Oct 25, 2026 • edited by dos Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Verification

📌 TL;DR

🎯 Type of Change

🔍 Changes Walkthrough

📊 Architectural Flow

Uh oh!

claude Bot left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot commented Oct 25, 2026

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot commented Oct 25, 2026

Uh oh!

coderabbitai Bot commented Oct 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

dos Bot left a comment

Choose a reason for hiding this comment

✅ CLEAN_PASS: Complete diff reviewed

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

dos Bot left a comment

Choose a reason for hiding this comment

✅ CLEAN_PASS: Complete diff reviewed

Uh oh!

JOY (JOY) commented Oct 25, 2026

Uh oh!

Uh oh!

JOY (JOY) commented Oct 25, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

JOY (JOY) commented Oct 25, 2026 •

edited by dos Bot

Loading

coderabbitai Bot commented Oct 25, 2026 •

edited

Loading