Skip to content

fix: trim WEB_SEARCH_PROVIDER env value #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prithvee07 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: trim WEB_SEARCH_PROVIDER env value #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/server/parallel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,16 @@ export interface WebConfig {
parallelApiKey?: string;
}
export function webSearchProvider(value?: string): WebSearchProvider {
if (!value) return 'parallel';
if (value === 'parallel' || value === 'browser' || value === 'disabled')
return value;
// Tolerate surrounding whitespace from .env files, matching the other
// environment parsers; a blank value falls back to the default.
const normalized = value?.trim();
if (!normalized) return 'parallel';
if (
normalized === 'parallel' ||
normalized === 'browser' ||
normalized === 'disabled'
)
return normalized;
throw new Error(
'WEB_SEARCH_PROVIDER must be parallel, browser, or disabled.',
);
Expand Down
5 changes: 5 additions & 0 deletions tests/parallel.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@ describe('Parallel research', () => {
expect(webSearchProvider('disabled')).toBe('disabled');
expect(() => webSearchProvider('other')).toThrow('WEB_SEARCH_PROVIDER');
});
it('tolerates surrounding whitespace from .env values', () => {
expect(webSearchProvider(' browser ')).toBe('browser');
expect(webSearchProvider('disabled\n')).toBe('disabled');
expect(webSearchProvider(' ')).toBe('parallel');
});
it('searches, extracts and grounds a topic-only brief without a browser', async () => {
mcp.callTool
.mockResolvedValueOnce(result(page(), page('https://example.org')))
Expand Down