Repository navigation
fix: trim WEB_SEARCH_PROVIDER env value - #161
Open
prithvee07 wants to merge 1 commit into
Open
prithvee07 wants to merge 1 commit into
prithvee07 wants to merge 1 commit into
Conversation
Every other environment parser (agentRunTimeoutMsFromEnv, firstNonEmptyEnvValue, slackUsers) trims surrounding whitespace, but webSearchProvider matched the raw value exactly. A .env entry with a trailing space such as `WEB_SEARCH_PROVIDER=parallel ` therefore crashed startup with a confusing validation error. Trim the value before matching, consistent with the other parsers, and treat a blank/whitespace-only value as unset (defaulting to parallel). Adds regression coverage for whitespace handling. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015a2if6nJJ2D6ZQGjiLGknv
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every other environment parser (agentRunTimeoutMsFromEnv, firstNonEmptyEnvValue, slackUsers) trims surrounding whitespace, but webSearchProvider matched the raw value exactly. A .env entry with a trailing space such as
WEB_SEARCH_PROVIDER=paralleltherefore crashed startup with a confusing validation error.Trim the value before matching, consistent with the other parsers, and treat a blank/whitespace-only value as unset (defaulting to parallel). Adds regression coverage for whitespace handling.