feat: block menus follow the shared menu parity fixture - #37
Merged
Merged
Conversation
tests/menu-parity.php runs every case of contentrain-menu-parity@1 (copied from Contentrain/ai #299, pinned) through Menus::from_blocks, with the fixture's public posts, terms and pages standing in for the site. Aligned with wp-import: a left-out link's children move up to its parent; a page list is a tree under parentPageID, by menu order then title; site-relative addresses are absolute; labels have tags stripped and entities decoded; a navigation keeps its own slug (navigation-<id> without one), suffixed -nav while a classic menu has it; an empty home link label is Home. target() takes a lookup so the fixture can stand in for WordPress.
Member
Author
|
t6 QA — Bridge #37 (6f9c829): ONAY, bir birleşme koşuluyla
Birleşme koşulu: Not (bloklamıyor): |
Member
Author
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copies
contentrain-menu-parity@1from Contentrain/ai #299 (pinned to its head824937c; re-pinned to the merged main commit once #299 merges) and runs every case throughMenus::from_blocks(tests/menu-parity.php, included by integration.php). 8/8 locally, 310 checks.Aligned with wp-import's rules:
parentPageID, by menu order then title (was: flat, every page)#stays#navigation-<id>without one,-navwhile a classic menu has itHomeMenus::target()takes an optional lookup (post,term) andfrom_blocks()optional pages, so the fixture stands in for WordPress; the default is the site as before. Draft navigations passed in are ignored and navigations are ordered by id.