Skip to content

chore: wp-import 0.5.7 — status parity compares the protected rows too - #28

Merged
ABB65 merged 2 commits into
mainfrom
chore/wp-import-057
Sep 25, 2026
Merged

ABB65 merged 2 commits into
mainfrom
chore/wp-import-057

Conversation

@ABB65

@ABB65 ABB65 commented Sep 24, 2026

Copy link
Copy Markdown
Member

Follow-up to #27 (QA-23). @contentrain/wp-import 0.5.7 ships Contentrain/ai #259 (a password-protected post → draft), so tests/status-parity.test.mjs now compares all 10 rows of tests/fixtures/status-parity.json against wp-import instead of reporting the 4 protected ones.

Change

  • devDependency @contentrain/wp-import 0.4.6 → 0.5.7 (exact), lock updated (its own @contentrain/types moves with it; Bridge's pinned @contentrain/types 1.14.0 is unchanged).
  • No plugin code changes: dev and test dependencies only; nothing ships in the plugin zip.

Evidence

  • node --test tests/status-parity.test.mjs → pass, no "predates #259" notice: 10/10 rows compared (4 protected → draft + visibility: password on both sides).
  • Installed 0.5.7 dist contains password_protected_drafts (2 matches); 0.4.6 had none.
  • CI is the reference for the other wp-import consumers (coverage-rawir.mjs A-03 parity, e2e), since this is a 0.4.6 → 0.5.7 jump.

Reviewer: QA.

@ABB65

ABB65 commented Sep 25, 2026

Copy link
Copy Markdown
Member Author

t9 review (second reviewer, 2cafb5d): APPROVED

Checked:

  • The only change is dev dependencies. package.json has an exact pin to 0.5.7. In the lockfile, the integrity for @contentrain/wp-import@0.5.7 and its nested @contentrain/types@1.22.0 match the npm registry exactly (npm view … dist.integrity). Bridge's own @contentrain/types 1.14.0 pin is unchanged, and nothing changes in the plugin zip.
  • In the acceptance log, status-parity.test.mjs passes and prints no "predates #259" warning, so all 10 rows are compared, including the 4 protected ones. PHP 7.4/8.3 syntax, small, small (10) and acceptance are all green.

Note (non-blocking):

  • N1: the test decides learned at runtime (published-protected → draft) and quietly falls back to a warning when it's false. Now that the pin is ≥ 0.5.7, that fallback is only a hiding place: if wp-import regresses, the test stays green and only a warning goes to the log. In a follow-up, make it a hard assertion (assert.ok(learned, …)) and remove the fallback branch.

@ABB65
ABB65 merged commit b36a7b8 into main Sep 25, 2026
8 checks passed
@ABB65
ABB65 deleted the chore/wp-import-057 branch September 25, 2026 22:09
@ABB65 ABB65 mentioned this pull request Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant