Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 75 additions & 0 deletions Sprint-2/implement_skip_list/skip_list.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@

import random

class Node:
__slots__ = ("value", "forward")

def __init__(self, value: int, level: int) -> None:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why restrict the value type to int?

Have you performed static type checking on the python script?

self.value = value
self.forward = [None] * (level + 1)


class SkipList:
def __init__(self) -> None:
self.max_level = 4
self.level = 0
self.head = Node(0, self.max_level)

def _random_level(self) -> int:
level = 0

while level < self.max_level and random.random() < 0.5:
level += 1

return level
def insert(self, value: int) -> None:
Comment on lines +24 to +25

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a blank line to separate two logically independent blocks of code could improve readability.

update = [self.head] * (self.max_level + 1)
current = self.head

for level in range(self.level, -1, -1):
while current.forward[level] is not None:
if current.forward[level].value < value:
current = current.forward[level]
else:
break
Comment on lines +30 to +34

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Code on line 30-34 could be simplified into a while-loop without using if-else. The same also applies to the while loop in contains() .


update[level] = current

node_level = self._random_level()
new_node = Node(value, node_level)

if node_level > self.level:
for i in range(self.level + 1, node_level + 1):
update[i] = self.head
self.level = node_level

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code on line 44 does not seem to depend on the loop.


for i in range(node_level + 1):
new_node.forward[i] = update[i].forward[i]
update[i].forward[i] = new_node

def contains(self, value: int | str) -> bool:
current = self.head

for level in range(self.level, -1, -1):
while current.forward[level] is not None:
if current.forward[level].value < value:
current = current.forward[level]
else:
break

current = current.forward[0]

return current is not None and current.value == value

def __contains__(self, value: int | str) -> bool:
return self.contains(value)

def to_list(self) -> list[int | str]:
result = []
current = self.head.forward[0]

while current is not None:
result.append(current.value)
current = current.forward[0]

return result
Loading