Repository navigation
Manchester | 26-SDC-Jun | Fithi Teklom | Sprint 2 | Implement Skip List - #263
Open
Fithi-Teklom wants to merge 1 commit into
Open
Fithi-Teklom wants to merge 1 commit into
Fithi-Teklom wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
Fithi-Teklom
added
the
Needs Review
cjyuan
reviewed
Oct 20, 2026
| class Node: | ||
| __slots__ = ("value", "forward") | ||
|
|
||
| def __init__(self, value: int, level: int) -> None: |
There was a problem hiding this comment.
Why restrict the value type to int?
Have you performed static type checking on the python script?
Comment on lines
+24
to
+25
| return level | ||
| def insert(self, value: int) -> None: |
There was a problem hiding this comment.
Adding a blank line to separate two logically independent blocks of code could improve readability.
Comment on lines
+30
to
+34
| while current.forward[level] is not None: | ||
| if current.forward[level].value < value: | ||
| current = current.forward[level] | ||
| else: | ||
| break |
There was a problem hiding this comment.
Note: Code on line 30-34 could be simplified into a while-loop without using if-else. The same also applies to the while loop in contains() .
| if node_level > self.level: | ||
| for i in range(self.level + 1, node_level + 1): | ||
| update[i] = self.head | ||
| self.level = node_level |
There was a problem hiding this comment.
Code on line 44 does not seem to depend on the loop.
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Task code
CYF-1185
Changelist
Implement skip list insert, search, and to_list methods