Skip to content

Give each code-result lesson test its own org - #969

Merged
zlareb1 merged 1 commit into
mainfrom
fix/code-result-lessons-test-isolation
Nov 19, 2026
Merged

zlareb1 merged 1 commit into
mainfrom
fix/code-result-lessons-test-isolation

Conversation

@zlareb1

@zlareb1 zlareb1 commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Related: #965
Related: #948

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

Changelog entry (one or two sentences a user of Loom can read without the diff; the release pull request collects these into the release notes):

Not required.

Why

Two lesson integration tests share an org, namespace and file path. When the partial-read case runs first, its stored lesson enters the exact-path case's result and fails the existing exact-key assertion.

Scope and risk

Each test now allocates its own registered org and passes it through writes, tokens and lesson reads. Both existing tests, all seven assertions and their timing limits are retained. The change covers one integration fixture module.

Compatibility, rollout and rollback

  • Wire: none.
  • Operator steps: none.
  • Rollback: restores the shared test identity.

Tests

The hosted failure contains the other test's exact lesson key and excerpt. The tested merge's fixture matches main. Python AST parsing, Ruff formatting, Ruff lint and whitespace checks pass. An exact reverse transformation restores the original fixture; all seven assertion lines are unchanged.

Local runtime execution was not run. Fresh independent whole-file source review has no findings or nits. All 46 hosted checks pass at c3d6c479b06c02a1f4a0681d7c30f970c88500b9.

AI assistance in the code (leave one; writing this description with AI is fine):

  • AI-generated: Codex wrote the fix. Org scope at every changed write, token and read was checked against the fixture and failure evidence.

  • I can explain every line of this diff and how it interacts with the rest of Loom.

Checklist

  • Required hosted CI passes at the final head.
  • Fresh independent review has no unresolved findings or nits.
  • Both tests and all seven assertions are retained.
  • Commits are signed off.

The two integration cases share a path and namespace. A row written by one case can enter the other case's exact result assertion when test order changes. Keep every assertion and pass a separate registered org through each case.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
@zlareb1
zlareb1 merged commit 933235c into main Nov 19, 2026
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant