Repository navigation
Give each code-result lesson test its own org - #969
Merged
Merged
Conversation
The two integration cases share a path and namespace. A row written by one case can enter the other case's exact result assertion when test order changes. Keep every assertion and pass a separate registered org through each case. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
6 tasks done
This was referenced Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #965
Related: #948
Changelog category (leave one):
Changelog entry (one or two sentences a user of Loom can read without the diff; the release pull request collects these into the release notes):
Not required.
Why
Two lesson integration tests share an org, namespace and file path. When the partial-read case runs first, its stored lesson enters the exact-path case's result and fails the existing exact-key assertion.
Scope and risk
Each test now allocates its own registered org and passes it through writes, tokens and lesson reads. Both existing tests, all seven assertions and their timing limits are retained. The change covers one integration fixture module.
Compatibility, rollout and rollback
Tests
The hosted failure contains the other test's exact lesson key and excerpt. The tested merge's fixture matches main. Python AST parsing, Ruff formatting, Ruff lint and whitespace checks pass. An exact reverse transformation restores the original fixture; all seven assertion lines are unchanged.
Local runtime execution was not run. Fresh independent whole-file source review has no findings or nits. All 46 hosted checks pass at
c3d6c479b06c02a1f4a0681d7c30f970c88500b9.AI assistance in the code (leave one; writing this description with AI is fine):
AI-generated: Codex wrote the fix. Org scope at every changed write, token and read was checked against the fixture and failure evidence.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist