Repository navigation
Conversation
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented by #969. This duplicate is closed; its source branch is preserved.
Related: #735
Changelog category (leave one):
Why
The code lesson tests share an org and namespace. The timeout test writes a lesson that the exact-path test then sees as an extra result. Give each test its own org so either order preserves the strict result assertion.
Scope and risk
One integration test module. Both tests use the existing org registration and cleanup helper. Their assertions stay unchanged. Production behavior, auth and stored data formats are unchanged.
Compatibility, rollout and rollback
Tests
AI assistance in the code (leave one; writing this description with AI is fine):
AI-generated: Codex wrote the fixture isolation change. The failure, org propagation and unchanged assertions were checked against the source.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist