Skip to content

Isolate code lesson tests by org - #971

Closed
zlareb1 wants to merge 1 commit into
mainfrom
fix/code-lesson-test-org-isolation
Closed

zlareb1 wants to merge 1 commit into
mainfrom
fix/code-lesson-test-org-isolation

Conversation

@zlareb1

@zlareb1 zlareb1 commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Implemented by #969. This duplicate is closed; its source branch is preserved.

Related: #735

Changelog category (leave one):

  • CI Fix or Improvement

Why

The code lesson tests share an org and namespace. The timeout test writes a lesson that the exact-path test then sees as an extra result. Give each test its own org so either order preserves the strict result assertion.

Scope and risk

One integration test module. Both tests use the existing org registration and cleanup helper. Their assertions stay unchanged. Production behavior, auth and stored data formats are unchanged.

Compatibility, rollout and rollback

  • Wire: none.
  • Operator steps: none.
  • Rollback: restores the shared test org; no data migration.

Tests

  • The failing integration job reports the extra lesson written by the other test.
  • Scoped Ruff, formatting and diff checks pass.
  • Both existing tests and every assertion are retained. Integration execution is deferred to PR CI; no local database suite was run.

AI assistance in the code (leave one; writing this description with AI is fine):

  • AI-generated: Codex wrote the fixture isolation change. The failure, org propagation and unchanged assertions were checked against the source.

  • I can explain every line of this diff and how it interacts with the rest of Loom.

Checklist

  • Full format, lint, type and test gates pass in PR CI.
  • Generated files, migrations, plugins, frontend, docs and wire contracts are unaffected.
  • Repository text has no dates, people, host names, internal namespaces, ticket or decision numbers.
  • Commits are signed off.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
@zlareb1 zlareb1 closed this Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant