Skip to content

Bound complete cell process census across polls - #915

Draft
zlareb1 wants to merge 1 commit into
feat/cell-shared-census-infrastructurefrom
feat/cell-bounded-process-census
Draft

zlareb1 wants to merge 1 commit into
feat/cell-shared-census-infrastructurefrom
feat/cell-bounded-process-census

Conversation

@zlareb1

@zlareb1 zlareb1 commented Nov 18, 2026

Copy link
Copy Markdown
Member

Related: #906
Related: #775
Related: #900

Changelog category (leave one):

  • Not for changelog

Why

A complete cell process census must retain obligations across polls. Separately bounded snapshots can otherwise omit processes during churn. This component shares the existing participant selection and topology checks, then applies explicit count, byte and deadline bounds to one attempt.

Scope and risk

The internal reader joins permanent participants, stored cell observations and web instances across every configured replica. It synchronizes replicated participant tables and uses sequential reads for shared tables. Each read shares an 8 MiB raw allowance. The attempt retains at most 1024 participant identities, 1024 observation identities and 8 MiB of protocol metadata, including retired history, without evicting obligations. Configured replicas are capped at 64.

Fingerprint, birth, role, protocol, acceptance, key and server-clock checks return unresolved obligations. Workers join without web instance rows. This component exposes no diagnostic route or activation operation. Native commands still need positive retirement; it grants no participant exemption.

Participant selection, the ordinary complete reader and the strict fingerprint codec move to shared owners. Their replaced definitions are removed. Ordinary update keeps its existing query and allowance. The bounded byte decoder is the exact existing implementation from the linked administration change. Observation production remains a separate dependency.

Compatibility, rollout and rollback

Wire changes: none. Settings, schema and operator steps: none. Existing ordinary update behavior is preserved. Reverting leaves no added durable state. This is stacked on the shared census infrastructure; complete native and mixed-build validation remains required before integration.

Tests

The fingerprint regression first produced two intended failures and one passing metadata-bound control. The same three cases and the directly related decoder, census, participant-conflict, ordinary-update and fingerprint-reservation tests then passed: 135 tests, no failures or skips.

pytest -q tests/unit/test_cell_observation_census.py tests/unit/test_cell_observation_census_stream.py tests/unit/test_ch_bounded_stream.py tests/unit/test_cell_participant_conflicts.py tests/unit/test_cell_update_participants.py tests/unit/test_cell_fingerprint_reservations.py

Scoped Ruff lint, formatting and statement limits pass. Independent source review found one fingerprint-limit defect; its correction is reviewed with no remaining findings. Native ClickHouse evaluation, process bootstrap, mixed builds and full CI remain pending. New component contract tests are not a pre-feature failure baseline.

AI assistance in the code (leave one; writing this description with AI is fine):

  • AI-generated: Codex wrote the change. Independent agent review checked the complete component, shared-owner preservation, bounds and failure paths; focused tests exercised the actual corrected source.

  • I can explain every line of this diff and how it interacts with the rest of Loom.

Checklist

  • Full CI and native integration pass before merge; only directly related local checks ran.
  • No generated API, settings, schema or CLI-surface output changes.
  • No migration, plugin or frontend change.
  • English architecture documentation describes the component; translations use the normal workflow.
  • Public text contains no deployment details.
  • Commits are signed off.

Retain every captured process obligation within one count, metadata and deadline allowance. Share the ordinary participant selection and strict fingerprint codec without changing update policy.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant