Repository navigation
Conversation
Retain every captured process obligation within one count, metadata and deadline allowance. Share the ordinary participant selection and strict fingerprint codec without changing update policy. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
2 of 4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #906
Related: #775
Related: #900
Changelog category (leave one):
Why
A complete cell process census must retain obligations across polls. Separately bounded snapshots can otherwise omit processes during churn. This component shares the existing participant selection and topology checks, then applies explicit count, byte and deadline bounds to one attempt.
Scope and risk
The internal reader joins permanent participants, stored cell observations and web instances across every configured replica. It synchronizes replicated participant tables and uses sequential reads for shared tables. Each read shares an 8 MiB raw allowance. The attempt retains at most 1024 participant identities, 1024 observation identities and 8 MiB of protocol metadata, including retired history, without evicting obligations. Configured replicas are capped at 64.
Fingerprint, birth, role, protocol, acceptance, key and server-clock checks return unresolved obligations. Workers join without web instance rows. This component exposes no diagnostic route or activation operation. Native commands still need positive retirement; it grants no participant exemption.
Participant selection, the ordinary complete reader and the strict fingerprint codec move to shared owners. Their replaced definitions are removed. Ordinary update keeps its existing query and allowance. The bounded byte decoder is the exact existing implementation from the linked administration change. Observation production remains a separate dependency.
Compatibility, rollout and rollback
Wire changes: none. Settings, schema and operator steps: none. Existing ordinary update behavior is preserved. Reverting leaves no added durable state. This is stacked on the shared census infrastructure; complete native and mixed-build validation remains required before integration.
Tests
The fingerprint regression first produced two intended failures and one passing metadata-bound control. The same three cases and the directly related decoder, census, participant-conflict, ordinary-update and fingerprint-reservation tests then passed: 135 tests, no failures or skips.
Scoped Ruff lint, formatting and statement limits pass. Independent source review found one fingerprint-limit defect; its correction is reviewed with no remaining findings. Native ClickHouse evaluation, process bootstrap, mixed builds and full CI remain pending. New component contract tests are not a pre-feature failure baseline.
AI assistance in the code (leave one; writing this description with AI is fine):
AI-generated: Codex wrote the change. Independent agent review checked the complete component, shared-owner preservation, bounds and failure paths; focused tests exercised the actual corrected source.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist