Repository navigation
Conversation
Use the shared client and executor for fixed diagnostic operations. Refuse oversized or unknown responses before parsing and protect marker cleanup with the exact contents and entity tag. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Read every permitted page before accepting marker absence. Bound the complete walk by objects, pages and UTF-8 key bytes, and refuse a foreign cell marker at any depth. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #915
Changelog category (leave one):
Changelog entry (one or two sentences a user of Loom can read without the diff; the release pull request collects these into the release notes):
Internal cell diagnostics exhaust bounded object-store prefixes, bound responses before parsing and delete an owned marker only with its exact contents and entity tag.
Why
A complete cell-separation check needs bounded listing pages and a marker cleanup that refuses a concurrent replacement. Ordinary object reads materialize response bodies and ordinary deletes do not provide that proof.
Scope and risk
Adds fixed-purpose listing and own-marker primitives through the existing cached client, shared executor and listing or transfer leases. A diagnostic client variant permits one request attempt, checks the installed SDK source and service model, bounds raw responses before the existing parser, and requires the store's response date. Its four operation hooks refuse implicit region redirects and unsupported signing before they can start another operation. Ordinary clients keep their current configuration and handlers.
Listing responses are limited to 8 MiB, operation errors to 64 KiB and marker reads to 1025 bytes. Marker contents are limited to 1024 bytes. Cleanup reads contents and the strong entity tag together, then uses one conditional delete; an unknown result or replacement remains incomplete. No arbitrary peer bucket, prefix, key or operation is accepted.
This component has no wire operation or activation caller. The configured-root walk inspects every permitted page and refuses a foreign cell marker at any depth. It accepts at most 100,000 objects, 100 pages and 16 MiB of UTF-8 key bytes per invocation; an incomplete final page at a limit refuses without another fetch. Authenticated peer barriers, shared-wait integration and actual store enforcement remain required before a physical-separation result can be claimed. The SDK identity check deliberately refuses unsupported installed versions or models.
Compatibility, rollout and rollback
Tests
AI assistance in the code (leave one; writing this description with AI is fine):
AI-generated (Codex): source, SDK path inspection, independent review, bounded transport and cleanup contracts, and scoped checks.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist