Repository navigation
Conversation
Move complete topology, catalog and synchronization implementations below CLI owners so server readers can reuse the same checks. Preserve SQL, refusal behavior and assertion contracts. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
6 of 7 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #776
Changelog category (leave one):
Changelog entry (one or two sentences a user of Loom can read without the diff; the release pull request collects these into the release notes):
Cell checks share the same topology, catalog and synchronization helpers across command and server code.
Why
Complete cell reads depend on topology validation, the caller's effective privileges, replica identity and synchronization. These implementations live in CLI modules, which server code cannot import. Shared owners let both layers use the same checks without copying them.
Scope and risk
The complete topology module moves to
server/core/cell_ch.py. Catalog, grant, default-role, row-policy and replica checks move toserver/insights/store/cell_catalog.py; synchronization and budget helpers move toserver/core/cell_sync.py. All callers and test patch points use those owners, and the old topology module is deleted.SQL, query settings and tags, defaults, refusal conditions, exception identity, row interpretation and ordinary update behavior remain unchanged. A missed caller import or patch point is the main risk. Bounded participant and observation joins remain unimplemented; this extraction adds no later-cell activation or readiness result.
Compatibility, rollout and rollback
Tests
AI assistance in the code (leave one; writing this description with AI is fine):
AI-generated: Codex. Independent review covers the complete extraction, import bindings, SQL and assertion preservation; final pushed-head review remains required.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist