Skip to content

fix trace is evm or eam check to return correct error code #7098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
akaladarshi wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix trace is evm or eam check to return correct error code #7098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,14 @@

### Changed

- [`#7066`](https://github.com/ChainSafe/forest/pull/7066): Disable JSON-RPC HTTP response compression by default. Set `FOREST_RPC_COMPRESS_MIN_BODY_SIZE` to a non-negative value (e.g. `1024`) to re-enable gzip compression of responses above that size.
- [#7066](https://github.com/ChainSafe/forest/pull/7066): Disable JSON-RPC HTTP response compression by default. Set `FOREST_RPC_COMPRESS_MIN_BODY_SIZE` to a non-negative value (e.g. `1024`) to re-enable gzip compression of responses above that size.

### Removed

### Fixed

- [#6748](https://github.com/ChainSafe/forest/issues/6748): Fixed trace transaction api returns the correct error.

## Forest v0.33.4 "Stray"

Mandatory release for mainnet node operators. It includes support for the _NV28 FireHorse_ network upgrade on mainnet, which is set to activate at epoch `6052800` (2026-05-27T14:00:00Z). It also includes a few improvements and fixes for the JSON-RPC server.
Expand Down
6 changes: 4 additions & 2 deletions src/rpc/methods/eth/trace/parity.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,10 @@ use tracing::debug;
/// Returns `true` if the invoked actor is an EVM contract or the Ethereum Account Manager.
fn trace_is_evm_or_eam(trace: &ExecutionTrace) -> bool {
if let Some(invoked_actor) = &trace.invoked_actor {
is_evm_actor(&invoked_actor.state.code)
|| invoked_actor.id != Address::ETHEREUM_ACCOUNT_MANAGER_ACTOR.id().unwrap()
let eam_actor_id = Address::ETHEREUM_ACCOUNT_MANAGER_ACTOR
.id()
.expect("EAM actor address should be an ID address");
is_evm_actor(&invoked_actor.state.code) || invoked_actor.id == eam_actor_id
} else {
false
}
Expand Down
Loading