Skip to content

fix trace is evm or eam check to return correct error code#7098

Draft
akaladarshi wants to merge 1 commit into
mainfrom
akaladarshi/fix-eam-evm-err-code
Draft

fix trace is evm or eam check to return correct error code#7098
akaladarshi wants to merge 1 commit into
mainfrom
akaladarshi/fix-eam-evm-err-code

Conversation

@akaladarshi
Copy link
Copy Markdown
Collaborator

Summary of changes

Changes introduced in this pull request:

  • Now trace_is_evm_or_eam returns correct error for only EVM and EAM actors

Reference issue to close (if applicable)

Closes #6748

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 22, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5c3fc431-5cb5-4cb3-9b02-8406493c89d2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch akaladarshi/fix-eam-evm-err-code
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch akaladarshi/fix-eam-evm-err-code

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix trace_is_evm_or_eam() guard to avoid misclassifying non-EVM actor exit codes as Parity EVM errors

1 participant