Skip to content

ci: type-check and test only, no separate binary builds - #2561

Merged
richiemcilroy merged 1 commit into
mainfrom
ci/gpui-test-only
Oct 14, 2026
Merged

richiemcilroy merged 1 commit into
mainfrom
ci/gpui-test-only

Conversation

@richiemcilroy

@richiemcilroy richiemcilroy commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Follow-up to #2553. PR CI now only type-checks (Clippy) and builds and runs the tests. It no longer builds release-style binaries on top of that.

Changes

  • Build GPUI Desktop: drops build-gpui-binary.sh debug. cargo test --bin cap-gpui already compiles and links the whole app crate. The GPUI source has no cfg(not(test)) code, so the binary build compiled nothing the test build doesn't. The two setup steps that script did for the tests (sync-desktop-versions.mjs and the patched zed checkout from prepare-gpui-dependency.sh) still run.
  • Rust tests (Linux): drops the cap-muxer/cap debug build. cargo test -p cap --bin cap still compiles and links the CLI, and Clippy type-checks cap-muxer on macOS and Windows.

On macOS the binary build also set MACOSX_DEPLOYMENT_TARGET, which the test step did not. Build scripts that track that variable were therefore compiled twice per run, and that goes away too.

Coverage notes

  • The Windows /STACK check on the cap-gpui binary (verify-windows-stack.mjs) now runs only in release builds, where build-gpui-binary.sh release already runs it.
  • Release builds of the binaries and sidecars are unchanged in desktop-release.yml.

Verification

  • actionlint clean.
  • This PR's CI is the first run with caches saved from main, so its job times are the warm numbers.

RetriggerConfidence Score: 5/5

The PR appears safe to merge.

Summary

This PR removes duplicate binary builds from CI while keeping dependency preparation and Rust tests.

  • CI tests no longer run separate debug binary builds.

Reviews (1) · Last reviewed commit: "ci: test GPUI and sidecars without separ..." · Reviewed by Greptile

@vercel

vercel Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
cap-status Ready Ready Preview Oct 14, 2026 6:52am UTC

@capy-ai capy-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capy found no issues.

View 2 other findings in Capy.

Open in Capy

@richiemcilroy
richiemcilroy merged commit 19b442f into main Oct 14, 2026
30 checks passed

This branch was successfully deployed

2 active deployments
Preview – cap-web — 0508c88e Deployed Oct 14, 2026 by vercel[bot]
Preview – cap-status — 0508c88e Deployed Oct 14, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant