Repository navigation
ci: type-check and test only, no separate binary builds - #2561
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2553. PR CI now only type-checks (Clippy) and builds and runs the tests. It no longer builds release-style binaries on top of that.
Changes
build-gpui-binary.sh debug.cargo test --bin cap-gpuialready compiles and links the whole app crate. The GPUI source has nocfg(not(test))code, so the binary build compiled nothing the test build doesn't. The two setup steps that script did for the tests (sync-desktop-versions.mjsand the patched zed checkout fromprepare-gpui-dependency.sh) still run.cap-muxer/capdebug build.cargo test -p cap --bin capstill compiles and links the CLI, and Clippy type-checkscap-muxeron macOS and Windows.On macOS the binary build also set
MACOSX_DEPLOYMENT_TARGET, which the test step did not. Build scripts that track that variable were therefore compiled twice per run, and that goes away too.Coverage notes
/STACKcheck on thecap-gpuibinary (verify-windows-stack.mjs) now runs only in release builds, wherebuild-gpui-binary.sh releasealready runs it.desktop-release.yml.Verification
actionlintclean.
Confidence Score: 5/5
The PR appears safe to merge.Summary
This PR removes duplicate binary builds from CI while keeping dependency preparation and Rust tests.
Reviews (1) · Last reviewed commit: "ci: test GPUI and sidecars without separ..." · Reviewed by Greptile