Repository navigation
ci: one desktop job per platform - #2563
Open
richiemcilroy wants to merge 3 commits into
Open
richiemcilroy wants to merge 3 commits into
richiemcilroy wants to merge 3 commits into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
|
hey @greptileai, please re-review the PR |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2553 and #2561. Each platform's desktop checks now run in one job, so a PR takes 1 macOS runner instead of up to 3.
Why
Hosted macOS concurrency is 5 runners. Each PR that touched recording code was holding 3 of them (Clippy, Build GPUI Desktop, A/V Sync Tests). Each of those jobs repeated checkout, native-deps setup and cache restore. This morning about 45 macOS jobs were queued behind 5 runners.
Changes
rustfilter gates Clippy and the root tests, and a newsyncfilter (the old sync-tests path list) gates the A/V sync steps. On main every step runs, so the onev1-rust-desktopcache per platform covers every step a PR can run.cap-recording --libandcap-enc-ffmpegrun once, not twice, when both filters match.sync-tests.yml, apart from the 6-case random matrix.sync-tests.ymlkeeps its nightly schedule (40 random cases) and manual dispatch, and drops its PR trigger.Trade-offs
Verification
actionlintclean on both workflows.
Confidence Score: 5/5
The PR appears safe to merge; the earlier skipped-check issue is fixed.Summary
The PR combines desktop checks into one job per platform and keeps the larger nightly A/V test run separate.
Reviews (2) · Last reviewed commit: "ci: run the desktop job for recording ha..." · Reviewed by Greptile