Skip to content

fix: no longer automatically execute cachetool task #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stijnbernards wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: no longer automatically execute cachetool task #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/Deployer/Task/After/CachetoolTask.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ class CachetoolTask extends TaskBase

public function register(): void
{
after('deploy:symlink', 'cachetool:clear:opcache');
after('cachetool:clear:opcache', 'cachetool:cleanup');
Copy link
Member

@tdgroot tdgroot Jun 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the after after('cachetool:clear:opcache' can remain, because when you actually make use of that task, you don't need to think about the cleanup.

Otherwise, I agree that this should be optional!

}

public function configure(Configuration $config): void
Expand Down