Skip to content

Conversation

@stijnbernards
Copy link
Contributor

Issue

Currently the Hypernode deploy always executes the cachetool opcache flush task.
This task is extremely flakey and fails a lot on our end. Same issue as on the Hipex servers.

Solution

This task can be safely removed, or at least marked optional as it's not required on Hypernode.

For reference see: https://deployer.org/docs/7.x/avoid-php-fpm-reloading
And in the Hypernode NGINX configuration /etc/nginx/fastcgi_params the following line fastcgi_param SCRIPT_FILENAME $realpath_root$fastcgi_script_name;
Which makes it so that no longer opcache has to be flushed.

I've tested this and validated this on multiple customers on our end.

Copy link
Member

@tdgroot tdgroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion, I agree that this should be optional! Some of our customers are actually relying on cachetool because they manually opted for disabling opcache revalidation so let's keep the task in here, but make it optional.

public function register(): void
{
after('deploy:symlink', 'cachetool:clear:opcache');
after('cachetool:clear:opcache', 'cachetool:cleanup');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the after after('cachetool:clear:opcache' can remain, because when you actually make use of that task, you don't need to think about the cleanup.

Otherwise, I agree that this should be optional!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants