Agentic UI: Fix crash when a toast is replaced in place with a different shape - #4443
Open
shaunandrews wants to merge 1 commit into
Open
Agentic UI: Fix crash when a toast is replaced in place with a different shape#4443shaunandrews wants to merge 1 commit into
shaunandrews wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
shaunandrews
marked this pull request as ready for review
August 4, 2026 19:17
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
stu-2162-site-header-actionsexploration)How AI was used in this PR
Claude Code cherry-picked this fix out of a larger exploration branch and verified it (the regression test, lint, typecheck) in isolation.
Proposed Changes
Fixes a crash that occurred when an app toast was updated in place and its content shape changed — for example, a running-sync toast transitioning into its success or failure result, where the result gains or loses a description. Previously React tried to update the existing
Noticeacross that shape change and crashed; now theNoticere-mounts cleanly instead, so the toast transitions smoothly with no crash.Testing Instructions
npm test -- apps/ui/src/components/app-toasts/index.test.tsx— it exercises the toast-shape transition directly and must pass.Pre-merge Checklist