Show sync progress in a running toast through push, pull, and preview - #4451
Draft
shaunandrews wants to merge 1 commit into
Draft
Show sync progress in a running toast through push, pull, and preview#4451shaunandrews wants to merge 1 commit into
shaunandrews wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Claude Code built and iterated on this live in the running app (including tracking down a Notice-hook crash); verified with typecheck and unit tests.
Proposed Changes
A push, pull, or preview can run for a while, and the header only has room to spin. This adds a running toast that opens when the sync starts, updates in place as it progresses, and is replaced in place by the result — one message for the whole operation, no pile-up.
sync-upload-progress) — the push connector now surfaces it via anonProgresscallback, mirroring pull. No main-process changes.Progress is throttled (~3/sec) so the aria-live announcer isn't re-rendered dozens of times a second, and the toast store treats a non-positive duration as "persist until replaced." Also folds in the fix for a crash when a toast is replaced in place with a different shape (a running toast losing its description at the result) — the
Noticeis keyed on its shape so it re-mounts cleanly. (That's the same fix as the trunk-side #4443, which this #4377-based stack doesn't have.)Testing Instructions
Pre-merge Checklist
RELEASE-NOTES.txtif necessary.