Return empty path when road-map Dijkstra cannot reach goal - #1419
Open
huxiaoyi-ovo wants to merge 2 commits into
Open
Return empty path when road-map Dijkstra cannot reach goal#1419huxiaoyi-ovo wants to merge 2 commits into
huxiaoyi-ovo wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
([], [])when the shared road-map Dijkstra search exhausts its frontierProblem
PathPlanning/VoronoiRoadMap/dijkstra_search.pyis shared by the Voronoi and visibility road-map planners. When no path exists, the search currently breaks out of the loop and then callsgenerate_final_path()with the untouched goal node. That produces a singleton[goal]path, which can be mistaken for a successful plan.This change makes the no-path result explicit and consistent with other planners in the repository by returning empty coordinate lists as soon as the open set is exhausted.
Tests
Added
tests/test_voronoi_dijkstra_search.pywith a disconnected three-node graph and asserts that an unreachable goal returns empty path lists.