Repository navigation
Table chart pagination (#219) and text-search facet (#99) - #562
Open
namedgraph wants to merge 4 commits into
Open
namedgraph wants to merge 4 commits into
namedgraph wants to merge 4 commits into
Conversation
… within its own LIMIT and from its own OFFSET Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… text their value contains Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ws no longer run out under the pager The design kit caps a block body that carries a pager at min(70vh, 620px) and expects a scroll box inside it. The chart canvas is not one, so once the table outgrew the cap its rows left the block under the pager. Same opt-out the grid view already has: the page scrolls the table, the pager follows it in flow. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…he same result set, and a view is what pages a query at the endpoint The chart's query goes out once, as stored, and is cached whole, as before the pager. A Table draws a slice of the held rows and the view's pager under it; the pager and the page size move the slice on the block's cache and redraw. No query is wrapped, limited or counted for any chart type, so a chart type picked anew redraws the held rows and never asks for them again. The subquery wrapper and the chart's COUNT go, and the result-count response is back to a view's own. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #219. Closes #99.
#219: a SELECT chart drawn as a Table pages its rows in the browser
ldh:ResultSetChartin Table mode pages. It draws a slice of the held rows,$ldh:page-sizeat a time, and the view's pager under it: the samediv.ldh-pagerhost andldh:PagerControlsmarkup, placed between the canvas and the footer. The "of N" total is the number of rows held.ldh.css), so the rows no longer run out under the pager once they outgrow the kit's 620px ceiling.ldh:replace-limit/ldh:replace-offsetnow replace only the query's own LIMIT/OFFSET, not a subquery's (CHANGELOG Fixed).#99: a facet on a string-ranged property filters by the text its value contains
rdfs:rangeisxsd:string,rdf:langStringorrdfs:Literal. It is a priority rule inldh:FilterInthat delegates to the newldh:FilterContains. There is no package hook yet.FILTER(isLiteral(?o) && CONTAINS(LCASE(STR(?o)), LCASE("…"))), standard SPARQL 1.1. Value-based, never label-based.ldh:FacetPill. A newldh:ResetFacetserves the popover's Clear, the pill's ×, and Clear all.Known limits
Verified
Browser checklist
"and\in the text; Clear, ×, and Clear all; non-string facets unchanged.🤖 Generated with Claude Code