Repository navigation
Replace SPARQL.js with Traqula (#429) - #563
Draft
namedgraph wants to merge 14 commits into
Draft
namedgraph wants to merge 14 commits into
namedgraph wants to merge 14 commits into
Conversation
…im hands the stylesheets flat triples with full IRIs and fills in the source locations and query members the generator needs Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s label, so the generator prints it and constructor instances, value-range markers and RDF/XML descriptions find it Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…raqula's AST, and its rewrites build EXISTS, IN and DESC the way Traqula's generator prints them Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ilds the CONSTRUCT it saves, in Traqula's AST Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ting in a modal and removing a resource build their triples and updates in Traqula's AST Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…able name, as Traqula keys VALUES rows Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…he parser shim adds when it generates the query Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…a as the browser's SPARQL parser, and the CHANGELOG records the switch Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…attern, a match pattern Saxon-HE compiles as well as Saxon-JS Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e Traqula port had keyed by its JSON node Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… a template triple, so the add-row button, which calls it from the HTML form, no longer passes the button to ldh:term-key Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The inline-creation submit keeps develop's containment check and derived title, with the linking and title triples built as Traqula terms. The text-search rewrite from #556 is ported to the Traqula shape: the bgp goes into where/patterns, and the query literal is no longer escaped by hand, since Traqula's generator escapes it on output. The constructor VALUES keeps develop's $for-class name and Traqula's sigil-less key. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #429. Supersedes #534. It builds on @dajiaohuang's commit from #534, kept with its original author, and finishes the port.
What's here
@traqulapackages are pinned to the 1.4.0 stable release.traqula.min.js(253 KB) is rebuilt from the lockfile, so the bundle committed in Replace SPARQL.js with Traqula #534 doesn't ship.src/main/js/sparql/index.js):[ … ]and( … )into plain triples.label. This is fixed inParseQuery.term(),ldh:typed-term-nodeandldh:term-node.ldh:alt-path-uris, parallax;Verified
client.xslcompiles to SEF with the Dockerfile'sxslt3-he. The serverlayout.xslandadmin/layout.xslcompile with Saxon-HE 12.9.ParseQueryTest(3/3).query-transforms.xsl, generated, then parsed by Jena and read. They cover paging, count, the container select, parallax, link predicates, facet counts, IN, ORDER BY, VALUES, regex escaping and constructor triples.Not verified (why this is a draft)
Nothing has run in Saxon-JS or a browser yet. Before merging, run these ui-tests:
document/blocks/view/*,document/blocks/chart/*,document/blocks/map,document/blocks/query;forms/*;overlays/modal/constructor-editor,document-form,delete-document,settings;shell/drawer/class-list,saved-views,document-tree/*;document/content-aside/concept-tree.Then run
make tests, includingstatic/content-type-charset.shandsignup.sh.Traqula parses more strictly than SPARQL.js, and stored view queries haven't been checked against it.
Generated queries print full IRIs with no PREFIX declarations, so GET query strings get longer.
Table chart pagination (#219) and text-search facet (#99) #562 adds new rewrites in
query-transforms.xslthat use the SPARQL.js shape. Whichever of the two PRs merges second has to port them.🤖 Generated with Claude Code