Skip to content

[driver] Separate class declaration from definition #14513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liwei1997 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[driver] Separate class declaration from definition #14513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions modules/drivers/lidar/robosense/driver/robosense_driver_component.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,21 @@
*****************************************************************************/

#include "modules/drivers/lidar/robosense/driver/robosense_driver_component.h"
namespace apollo {
namespace drivers {
namespace robosense {
bool RobosenseComponent::Init() {
if (!GetProtoConfig(&conf_)) {
AERROR << "load config error, file:" << config_file_path_;
return false;
}
driver_.reset(new RobosenseDriver(node_, conf_));
if (!driver_->Init()) {
AERROR << "driver init error";
return false;
}
return true;
}
} // namespace robosense
} // namespace drivers
} // namespace apollo
13 changes: 1 addition & 12 deletions modules/drivers/lidar/robosense/driver/robosense_driver_component.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,18 +31,7 @@ using apollo::cyber::Component;
class RobosenseComponent : public Component<> {
public:
~RobosenseComponent() {}
bool Init() override {
if (!GetProtoConfig(&conf_)) {
AERROR << "load config error, file:" << config_file_path_;
return false;
}
driver_.reset(new RobosenseDriver(node_, conf_));
if (!driver_->Init()) {
AERROR << "driver init error";
return false;
}
return true;
}
bool Init() override;

private:
std::shared_ptr<RobosenseDriver> driver_;
Expand Down