Fix clippy and formatting lints from stable toolchain drift

ffi/src/lib.rs

@@ -522,7 +522,11 @@ pub unsafe extern "C" fn builder_build(
     let allocate_fn = builder_box.allocate_fn;
     unsafe {
         catch_unwind_into_extern_result(&allocate_fn, move || {
-            get_default_engine_impl(builder_box.url, builder_box.options, builder_box.allocate_fn)
+            get_default_engine_impl(
+                builder_box.url,
+                builder_box.options,
+                builder_box.allocate_fn,
+            )
         })
     }
 }
@@ -555,8 +559,11 @@ unsafe fn catch_unwind_into_extern_result<T>(
     alloc: &dyn AllocateError,
     f: impl FnOnce() -> DeltaResult<T>,
 ) -> ExternResult<T> {
-    let result = std::panic::catch_unwind(std::panic::AssertUnwindSafe(f))
-        .unwrap_or_else(|_| Err(Error::generic("delta-kernel-rs panicked across the FFI boundary")));
+    let result = std::panic::catch_unwind(std::panic::AssertUnwindSafe(f)).unwrap_or_else(|_| {
+        Err(Error::generic(
+            "delta-kernel-rs panicked across the FFI boundary",
+        ))
+    });
     unsafe { result.into_extern_result(alloc) }
 }
 

ffi/src/scan.rs

@@ -624,5 +624,4 @@ mod tests {
         let final_map: HashMap<String, String> = *unsafe { Box::from_raw(map_ptr) };
         assert_eq!(test_map, final_map);
     }
-
 }

ffi/src/table_changes.rs

@@ -22,8 +22,8 @@ use crate::expressions::kernel_visitor::{unwrap_kernel_predicate, KernelExpressi
 use crate::scan::EnginePredicate;
 use crate::{
     catch_unwind_into_extern_result, kernel_string_slice, unwrap_and_parse_path_as_url,
-    AllocateStringFn, ExternEngine, ExternResult, IntoExternResult, KernelStringSlice,
-    NullableCvoid, SharedExternEngine, SharedSchema,
+    AllocateStringFn, ExternEngine, ExternResult, KernelStringSlice, NullableCvoid,
+    SharedExternEngine, SharedSchema,
 };
 
 #[handle_descriptor(target=TableChanges, mutable=true, sized=true)]

kernel/src/actions/visitors.rs

@@ -99,7 +99,7 @@
 
 impl AddVisitor {
     #[internal_api]
     fn visit_add<'a>(
         row_index: usize,
         path: String,
         getters: &[&'a dyn GetData<'a>],
@@ -172,7 +172,7 @@
 
 impl RemoveVisitor {
     #[internal_api]
     pub(crate) fn visit_remove<'a>(
         row_index: usize,
         path: String,
         getters: &[&'a dyn GetData<'a>],
@@ -248,7 +248,7 @@
 
 impl CdcVisitor {
     #[internal_api]
     pub(crate) fn visit_cdc<'a>(
         row_index: usize,
         path: String,
         getters: &[&'a dyn GetData<'a>],
@@ -826,7 +826,7 @@
         };
         let expected = vec![add1, add2, add3];
         assert_eq!(add_visitor.adds.len(), expected.len());
-        for (add, expected) in add_visitor.adds.into_iter().zip(expected.into_iter()) {
+        for (add, expected) in add_visitor.adds.into_iter().zip(expected) {
             assert_eq!(add, expected);
         }
     }

kernel/src/engine/parquet_row_group_skipping.rs

@@ -208,6 +208,7 @@ impl ParquetStatsProvider for RowGroupFilter<'_> {
             // physical name mapping has been performed. Because we currently lack both the
             // validation and the name mapping support, we must disable this optimization for the
             // time being. See https://github.com/delta-io/delta-kernel-rs/issues/434.
+            #[allow(unknown_lints, clippy::some_filter)]
             return Some(self.get_parquet_rowcount_stat()).filter(|_| false);
         };
 

kernel/src/scan/mod.rs

@@ -589,7 +589,10 @@ impl Scan {
         &self,
         engine: Arc<dyn Engine>,
     ) -> DeltaResult<impl Iterator<Item = DeltaResult<Box<dyn EngineData>>>> {
-        fn scan_metadata_callback(batches: &mut Vec<state::ScanFile>, file: state::ScanFile) -> bool {
+        fn scan_metadata_callback(
+            batches: &mut Vec<state::ScanFile>,
+            file: state::ScanFile,
+        ) -> bool {
             batches.push(file);
             true
         }

kernel/src/schema/mod.rs

@@ -1110,6 +1110,7 @@ impl ColumnNamesAndTypes {
         (&self.0, &self.1)
     }
 
+    #[allow(dead_code)]
     pub(crate) fn extend(&mut self, other: ColumnNamesAndTypes) {
         self.0.extend(other.0);
         self.1.extend(other.1);