Repository navigation
Conversation
subkanthi
force-pushed
the
fix-clippy-stable-lints
branch
from
October 6, 2026 16:32
30cbf2b to
65d8dac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI workflow runs
cargo clippy ... -- -D warningsandcargo fmt -- --checkwith a floating stable Rust toolchain. Newer stable releases (1.96+) introduced stricter lints that flag pre-existing code on theClickHouse/v0.19.2-with-panic-safe-ffibase branch:dead_code:ColumnNamesAndTypes::extendinkernel/src/schema/mod.rsis never called. Fixed with#[allow(dead_code)].clippy::some_filter(new in 1.99):Some(x).filter(|_| false)inkernel/src/engine/parquet_row_group_skipping.rs— deliberately disabled code (references upstream issue Parquet row group skipping is broken/unsafe for missing columns delta-io/delta-kernel-rs#434). Fixed with#[allow(unknown_lints, clippy::some_filter)]to preserve intent across toolchain versions.unused_imports:IntoExternResultimported but unused inffi/src/table_changes.rs. Removed.clippy::useless_conversion:.into_iter()on aVecpassed to.zip()inkernel/src/actions/visitors.rstest code. Simplified.cargo fmt: formatting drift in several files from thecatch_unwindpatches. Appliedcargo fmt.All lints are pre-existing on the base branch and unrelated to PR #1.
Failing CI run: https://github.com/Altinity/delta-kernel-rs/actions/runs/37404771416
Related: #1