Skip to content

fix: manual water annotation qc plot - #97

Merged
arjunsridhar12345 merged 3 commits into
devfrom
95-fix-manual-water-annotation
Sep 14, 2026
Merged

arjunsridhar12345 merged 3 commits into
devfrom
95-fix-manual-water-annotation

Conversation

@arjunsridhar12345

Copy link
Copy Markdown
Collaborator

Attempts to close #95. The 3rd panel in the side bias qc plot was missing the manual water annotation. Looking at session 864253_2026-09-02_13-19-38, there are 5 manual waters in the software event GiveManualWaterRight, 2 right (data field is True), and 3 left:

{"name":"GiveManualWaterRight","timestamp":6123056.335584,"timestamp_source":"harp","frame_index":null,"frame_timestamp":null,"data":false,"data_type":"object","data_type_hint":null}
{"name":"GiveManualWaterRight","timestamp":6123063.617568,"timestamp_source":"harp","frame_index":null,"frame_timestamp":null,"data":true,"data_type":"object","data_type_hint":null}
{"name":"GiveManualWaterRight","timestamp":6123086.651584,"timestamp_source":"harp","frame_index":null,"frame_timestamp":null,"data":true,"data_type":"object","data_type_hint":null}
{"name":"GiveManualWaterRight","timestamp":6123557.707584,"timestamp_source":"harp","frame_index":null,"frame_timestamp":null,"data":false,"data_type":"object","data_type_hint":null}
{"name":"GiveManualWaterRight","timestamp":6124366.751584,"timestamp_source":"harp","frame_index":null,"frame_timestamp":null,"data":false,"data_type":"object","data_type_hint":null}

Sample update of qc plot below:

image

Zooming in to beginning, can see 3 manual water, and then 2 later on from above image. End up with 2 right and 3 left.

image

NOTE: this does not take into account go-cue-aligned manual waters being differentiated from auto-rewards which will be a seperate PR once the software event has been added. This PR only deals with fixing the qc plot and missing legend.

@alexpiet

alexpiet commented Sep 9, 2026

Copy link
Copy Markdown

This is probably a separate issue, but why is the software event GiveManualWaterRight with a data field that toggles left/right? Wouldn't it make more sense to have separate software events for left/right manual water, or rename the event to GiveManualWater and then have a data field with left/right?

@alexpiet

alexpiet commented Sep 9, 2026

Copy link
Copy Markdown

Why don't we see a manual water on the left side for trial 0 on the zoomed-out plot? Is it because the x-axis is clipped to left=0? We want to be able to see the manual water on trial 0. We could

  • adjust the x limits to be left=-1 (probably the best)
  • use clip_on=False to plot on top of the axis line

@alexpiet alexpiet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address the two comments. The first probably makes sense to split into a separate ticket

@arjunsridhar12345

Copy link
Copy Markdown
Collaborator Author

This is probably a separate issue, but why is the software event GiveManualWaterRight with a data field that toggles left/right? Wouldn't it make more sense to have separate software events for left/right manual water, or rename the event to GiveManualWater and then have a data field with left/right?

I think this is a question for @micahwoodard.

Why don't we see a manual water on the left side for trial 0 on the zoomed-out plot? Is it because the x-axis is clipped to left=0? We want to be able to see the manual water on trial 0. We could

adjust the x limits to be left=-1 (probably the best)

use clip_on=False to plot on top of the axis line

yeah I believe its clipped, I'll try with adjusting the x limits and see

@arjunsridhar12345

Copy link
Copy Markdown
Collaborator Author

I tried to adjust the x limits. how does this look? it shows up now without needing to zoom it, but is there enough space to see it or should we be more aggressive in adjusting the limits?

image

@alexpiet alexpiet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the xaxis limits, they look good now. I split the other issue off: https://github.com/AllenNeuralDynamics/DF-Refactoring/issues/220

@arjunsridhar12345
arjunsridhar12345 merged commit 9d79fcb into dev Sep 14, 2026
3 checks passed
@arjunsridhar12345
arjunsridhar12345 deleted the 95-fix-manual-water-annotation branch September 15, 2026 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants