chore: Migrate to oxfmt#247
Conversation
Jarbuckle
left a comment
Jarbuckle
left a comment
There was a problem hiding this comment.
Generally looks fine, but have a few notes below. I find it interesting how the default formatting for HTML/JSX is to expand basically everything that has any number of attributes/props into multiple lines; I feel like that might be a negative from a readability perspective, but it's not that big an issue for me.
| export class AsyncDataCache<SemanticKey extends RecordKey, CacheKey extends RecordKey, D> implements AsyncCache< | ||
| SemanticKey, | ||
| CacheKey, | ||
| D | ||
| > { |
There was a problem hiding this comment.
This one doesn't really feel like a readability improvement to me 🤔
| - Add helpful linting rules ([#127](https://github.com/AllenInstitute/vis/pull/127)) | ||
| - Dev command, reorganized docs, added stubs ([#163](https://github.com/AllenInstitute/vis/pull/163)) | ||
| - *(deps)* Bump @biomejs/biome from 1.9.4 to 2.0.6 ([#174](https://github.com/AllenInstitute/vis/pull/174)) | ||
| - _(deps)_ Bump @biomejs/biome from 1.9.4 to 2.0.6 ([#174](https://github.com/AllenInstitute/vis/pull/174)) |
There was a problem hiding this comment.
Ah, okay, this feels like a good argument in favor of formatting .md files -- using underscores instead of asterisks for italicization is much less than confusing, since it's not competing with the asterisks for bold.
| <Card | ||
| title="ABC Atlas" | ||
| icon="rocket" | ||
| > | ||
| The [Allen Brain Cell Atlas (ABC Atlas)](https://knowledge.brain-map.org/abcatlas) uses | ||
| `@alleninstitute/vis-core` to visualize millions of points of data in the browser. | ||
| </Card> | ||
| <Card | ||
| title="GTA" | ||
| icon="magnifier" | ||
| > | ||
| The [Genetic Tools Atlas | ||
| (GTA)](https://knowledge.brain-map.org/data/7CVKSF7QGAKIQ8LM5LC/specimens/HTS03VQD4BBB67I3BAP) uses | ||
| `@alleninstitute/vis-omezarr` to display OME-Zarr previews. | ||
| </Card> | ||
| <Card | ||
| title="DZI" | ||
| icon="information" | ||
| > | ||
| The [SEA-AD project](https://knowledge.brain-map.org/data/JGN327NUXRZSHEV88TN/specimens/JGCXWER774NLNWX2NNR) |
There was a problem hiding this comment.
It seems to be very keen on multi-lining any elements that have multiple props 🤔
| "check": "oxfmt --check && biome lint .", | ||
| "check:fix": "oxfmt && biome lint . --write", |
| }, | ||
| "volta": { | ||
| "node": "22.11.0", | ||
| "node": "24.15.0", |
There was a problem hiding this comment.
Had to go to at least 22.13 (I think), figured might as well hop on the 24 LTS train now!
2 participants
What
Replaces
biomeformatter withoxfmtHow
Pulled the
oxfmtfile from our other projectsInstalled
oxfmtRemoved
biomeformatting stuffPR Checklist
main?