[Common] Fix TPC side determination in VDrift correction - #17846
Open
matthias-kleiner wants to merge 5 commits into
Open
matthias-kleiner wants to merge 5 commits into
matthias-kleiner wants to merge 5 commits into
Conversation
matthias-kleiner
requested review from
a team,
alibuild,
ddobrigk,
dsekihat,
iarsene,
jgrosseo and
ktf
as code owners
September 9, 2026 15:05
|
O2 linter results: ❌ 0 errors, |
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ddobrigk
previously approved these changes
Sep 11, 2026
Collaborator
|
Hi @matthias-kleiner, thanks a lot for this fix! However, I was wondering what will happen with data for which the TPC side flags are not stored: this is relevant, since those were added only in February this year. Further, since they were added "adiabatically" by taking unused bits in the flags integer, older datasets will appear to have all tracks only in one side, and thus the fix will break in that situation. Is there perhaps some way in which the TPC side information could be inferred from other parameters that existed already before? For instance, a combination of tgl and the sign of Z (given we store tracks at the position of their innermost update?)... Sorry if I am overlooking something. Thanks again! |
The TPCSideA/TPCSideC flags were only added to the AOD format in February 2026, so datasets produced before that always have neither bit set. Detect CE-crossing tracks from the track's asymmetric time margins and otherwise infer the side from a cross-check of Z and tgl sign, per TPC domain expert guidance, instead of silently skipping the correction for all tracks in older datasets. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Author
Hi @ddobrigk , |
shahor02
previously approved these changes
Sep 11, 2026
Collaborator
|
Hi @matthias-kleiner, thanks a lot! I have one question and a request, if I may:
Thanks again - and please only worry about this whenever convenient and don't let me disturb your weekend! |
Collaborator
|
Error while checking build/O2Physics/code-check for be7148b at 2026-09-14 04:43: Full log here. |
Introduce TPCVDriftManagerParam::useSideBasedCorrection (default off) to gate the new TPC-side-flag-based correction behind a ConfigurableParam, settable from any workflow via --configKeyValues without touching each task that owns a TPCVDriftManager instance. Keeps existing analyses on the legacy tgl-sign behaviour until explicitly opted in for testing. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Author
Hi @ddobrigk , I think it could in principle recover some efficiency loss: when the sign of the tgl disagrees with the actual TPC side, the old code shifts the tracks Z the wrong way instead of correcting it, which would hurt topological cuts. How much depends on how large the vDrift correction is and how often the vertex position/track topology puts tgl and Z sign at different sign. The best would be to make a direct A/B comparison with the switch. |
ddobrigk
previously approved these changes
Sep 14, 2026
ddobrigk
enabled auto-merge (squash)
September 14, 2026 13:21
ddobrigk
disabled auto-merge
September 14, 2026 15:13
Collaborator
Collaborator
|
Error while checking build/O2Physics/staging for ec64032 at 2026-09-14 21:21: Full log here. |
Collaborator
Collaborator
|
Hi @matthias-kleiner ! Thank you very much for the PR! I have taken the liberty to try out your changes in order to test whether the configurable is available in the The simplest alternative is maybe to add the variable My 2 cents. |
…e-based correction switch O2ParamDef only declares the static sInstance member; defining it requires O2ParamImpl in a compiled .cxx, but TPCVDriftManager is a header-only library with none, so Instance() left an unresolved symbol for every consumer. Switch to a plain member + setter, as suggested in review; tasks using TPCVDriftManager can later expose this via their own Configurable. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Author
Hi @romainschotter , |
Collaborator
|
Many, many thanks @matthias-kleiner ! (and @romainschotter for taking a look too). Will approve |
ddobrigk
approved these changes
Sep 15, 2026
ddobrigk
enabled auto-merge (squash)
September 15, 2026 07:40
Collaborator
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.