Resolve original condition ids in reinit - #3230
Open
BSnelling wants to merge 4 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3230 +/- ##
=======================================
Coverage 78.59% 78.60%
=======================================
Files 318 318
Lines 21106 21122 +16
Branches 1487 1487
=======================================
+ Hits 16589 16602 +13
- Misses 4509 4512 +3
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
BSnelling
force-pushed
the
bes/cond_state_resolution
branch
from
August 12, 2026 10:11
45e3dde to
5aed7ce
Compare
BSnelling
marked this pull request as ready for review
August 12, 2026 10:50
FFroehlich
approved these changes
Aug 12, 2026
Member
|
@dweindl does this look good to you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the function
_condition_reinit_target_valueto resolve conditions ids in the same way as_eval_nndoes, while preserving gradient tracing.The context in which I noticed this bug was a JAXProblem built from a PetabImporter instance. The underlying petab problem contained conditions which modified a model state variable. The PetabImporter changes the names of conditions and condition targets as part of import which is why
_eval_nnneeds to resolve current condition ids to originals, and why_condition_reinit_target_valueshould do the same.